Re: [PATCH v2 13/18] uaccess: generalize access_ok()

Arnd Bergmann
2022-02-24T08:41:29Z

On Thu, Feb 24, 2022 at 9:29 AM Stafford Horne <shorne@gmail.com> wrote:

> > -
> > -#define access_ok(addr, size) \
> > -({ \
> > - __chk_user_ptr(addr); \
> > - __range_ok((unsigned long)(addr), (size)); \
> > -})
> > +#include <asm-generic/access_ok.h>
>
> I was going to ask why we are missing __chk_user_ptr in the generic version.
> But this is basically now a no-op so I think its OK.

Correct, the type checking is implied by making __access_ok() an inline
function that takes a __user pointer.

> Acked-by: Stafford Horne <shorne@gmail.com> [openrisc, asm-generic]

Thanks!

Arnd