From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Tracy Subject: Re: 5.17.0 boot issue on Miata Date: Mon, 18 Apr 2022 23:53:50 -0500 Message-ID: References: <20220326222157.GA13650@tower> <20220405050125.GA25969@tower> <10d61d8f-edfc-fc39-0936-233692464dbd@gmx.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Resent-Message-ID: List-Id: List-URL: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Archive: https://lists.debian.org/msgid-search/Yl5AXvU+cBH5ex4K@gherkin.frus.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: debian-alpha@lists.debian.org Cc: Michael Cree , linux-alpha@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org (Adding linux-scsi and linux-kernel, now that bisection is complete.) On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote: > v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I > reported in the first message in this thread. This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller. Here's the implicated commit: edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 Author: Ming Lei Date: Thu Jan 27 23:37:33 2022 +0800 scsi: core: Reallocate device's budget map on queue depth change We currently use ->cmd_per_lun as initial queue depth for setting up the budget_map. Martin Wilck reported that it is common for the queue_depth to be subsequently updated in slave_configure() based on detected hardware characteristics. As a result, for some drivers, the static host template settings for cmd_per_lun and can_queue won't actually get used in practice. And if the default values are used to allocate the budget_map, memory may be consumed unnecessarily. Fix the issue by reallocating the budget_map after ->slave_configure() returns. At that time the device queue_depth should accurately reflect what the hardware needs. Link: https://lore.kernel.org/r/20220127153733.409132-1-ming.lei@redhat.com Cc: Bart Van Assche Reported-by: Martin Wilck Suggested-by: Martin Wilck Tested-by: Martin Wilck Reviewed-by: Martin Wilck Reviewed-by: Bart Van Assche Signed-off-by: Ming Lei Signed-off-by: Martin K. Petersen drivers/scsi/scsi_scan.c | 55 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 50 insertions(+), 5 deletions(-) Respectfully, --Bob