From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 1/6] ia64, processor: fix -Wincompatible-pointer-types in ia64_get_irr() Date: Fri, 10 Jun 2022 16:46:21 +0300 Message-ID: References: <20220610113427.908751-1-alexandr.lobakin@intel.com> <20220610113427.908751-2-alexandr.lobakin@intel.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654868792; x=1686404792; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ravTgUnKG4C+bKIq95tFE0q0c60bszYzURjmYJ4owCY=; b=K7AyFHdPnXsk0KEWuJAxX7QZT133eEFKuejLuhSP4XcKmarPFG2JzYHx sLO8v4Dve6m07IAY2r4OUBjsgGLgC5n4FGaHB4U7pWlfMvY1HsI80G7YL Yi5cB2vTAMPycmSQyaerOQe+y/gEeUCTrqKQjZBekkYnlS3cvy3h5p/gT Qj4GfnBjhjKsrVGSXh/UfyJZZdH8R4mc/PmhqEB8Q7QF0CuzKYuscx6Ly t5jLOSQDb4y/Um+aZo9Fkd3JaMhn0NahioElwSXtoSmSfl389lcVYIOSn NHuS/7CZhZX3GCNrmb+9RO/9pdDWLZt8Thk+ybxU7fFCAqqFpB/HFEcmD Q==; Content-Disposition: inline In-Reply-To: <20220610113427.908751-2-alexandr.lobakin@intel.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Lobakin Cc: Arnd Bergmann , Yury Norov , Mark Rutland , Matt Turner , Brian Cain , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Marco Elver , Borislav Petkov , Tony Luck , Greg Kroah-Hartman , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-ke On Fri, Jun 10, 2022 at 01:34:22PM +0200, Alexander Lobakin wrote: > test_bit(), as any other bitmap op, takes `unsigned long *` as a > second argument (pointer to the actual bitmap), as any bitmap > itself is an array of unsigned longs. However, the ia64_get_irr() > code passes a ref to `u64` as a second argument. > This works with the ia64 bitops implementation due to that they > have `void *` as the second argument and then cast it later on. > This works with the bitmap API itself due to that `unsigned long` > has the same size on ia64 as `u64` (`unsigned long long`), but > from the compiler PoV those two are different. > Define @irr as `unsigned long` to fix that. That implies no > functional changes. Has been hidden for 16 years! Reviewed-by: Andy Shevchenko > Fixes: a58786917ce2 ("[IA64] avoid broken SAL_CACHE_FLUSH implementations") > Cc: stable@vger.kernel.org # 2.6.16+ > Reported-by: kernel test robot > Signed-off-by: Alexander Lobakin > --- > arch/ia64/include/asm/processor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/ia64/include/asm/processor.h b/arch/ia64/include/asm/processor.h > index 7cbce290f4e5..757c2f6d8d4b 100644 > --- a/arch/ia64/include/asm/processor.h > +++ b/arch/ia64/include/asm/processor.h > @@ -538,7 +538,7 @@ ia64_get_irr(unsigned int vector) > { > unsigned int reg = vector / 64; > unsigned int bit = vector % 64; > - u64 irr; > + unsigned long irr; > > switch (reg) { > case 0: irr = ia64_getreg(_IA64_REG_CR_IRR0); break; > -- > 2.36.1 > -- With Best Regards, Andy Shevchenko