From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-alpha@vger.kernel.org
Subject: Re: [PATCH v2 7/7] alpha: lazy FPU switching
Date: Fri, 2 Sep 2022 06:14:33 +0100 [thread overview]
Message-ID: <YxGROdeUQHG4XPH9@ZenIV> (raw)
In-Reply-To: <YxGPk1dDyCP2AWul@ZenIV>
On Fri, Sep 02, 2022 at 06:07:31AM +0100, Al Viro wrote:
> > With the asm even having a comment about how it only works because
> > alpha doesn't do preemption (ARCH_NO_PREEMPT), but then the C code
> > does do those preempt_disable/enable pairs, and I see an actual bug in
> > there too:
> >
> > Both alpha_read_fp_reg() and alpha_read_fp_reg_s() do a
> > preempt_enable() -> preempt_enable() pair (ie the first one should be
> > a preempt_disable()).
>
> Will fix.
Done and pushed. IIRC, that started as a similar comment re
"we'd need to disable preemption here if we ever grow one on alpha",
but I ended up looking at it and deciding that it's easier to just
go ahead and call preempt_disable()/preempt_enable() instead
of comments.
prev parent reply other threads:[~2022-09-02 5:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 2:54 [PATCHES] alpha asm glue cleanups and fixes Al Viro
2021-09-25 2:55 ` [PATCH 1/6] alpha: fix TIF_NOTIFY_SIGNAL handling Al Viro
2021-09-25 2:55 ` [PATCH 2/6] alpha: _TIF_ALLWORK_MASK is unused Al Viro
2021-09-25 2:55 ` [PATCH 3/6] alpha: fix syscall entry in !AUDUT_SYSCALL case Al Viro
2021-09-25 2:55 ` [PATCH 4/6] alpha: fix handling of a3 on straced syscalls Al Viro
2021-09-25 2:55 ` [PATCH 5/6] alpha: syscall exit cleanup Al Viro
2021-09-25 2:55 ` [PATCH 6/6] alpha: ret_from_fork can go straight to ret_to_user Al Viro
2021-09-25 2:55 ` [PATCH 7/7] alpha: lazy FPU switching Al Viro
2021-09-25 19:07 ` Linus Torvalds
2021-09-25 20:43 ` Al Viro
2021-09-25 23:18 ` Linus Torvalds
2021-09-26 0:31 ` Al Viro
2021-10-30 20:46 ` Al Viro
2021-10-30 20:46 ` Al Viro
2021-10-30 21:25 ` Maciej W. Rozycki
2021-10-30 22:13 ` Al Viro
2021-09-26 9:08 ` John Paul Adrian Glaubitz
2021-09-25 2:59 ` [PATCHES] alpha asm glue cleanups and fixes Al Viro
2022-09-02 1:48 ` Al Viro
2022-09-02 1:50 ` [PATCH v2 1/7] alpha: fix TIF_NOTIFY_SIGNAL handling Al Viro
2022-09-02 1:50 ` [PATCH v2 2/7] alpha: _TIF_ALLWORK_MASK is unused Al Viro
2022-09-02 1:50 ` [PATCH v2 3/7] alpha: fix syscall entry in !AUDUT_SYSCALL case Al Viro
2022-09-02 1:50 ` [PATCH v2 4/7] alpha: fix handling of a3 on straced syscalls Al Viro
2022-09-02 1:50 ` [PATCH v2 5/7] alpha: syscall exit cleanup Al Viro
2022-09-02 1:50 ` [PATCH v2 6/7] alpha: ret_from_fork can go straight to ret_to_user Al Viro
2022-09-02 1:50 ` [PATCH v2 7/7] alpha: lazy FPU switching Al Viro
2022-09-02 4:24 ` Linus Torvalds
2022-09-02 5:07 ` Al Viro
2022-09-02 5:14 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxGROdeUQHG4XPH9@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-alpha@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).