From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65FF01547E2 for ; Thu, 3 Oct 2024 16:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727974017; cv=none; b=c7PrUERK0YOXp4rhG9mbpu0kYwcXBvGT9Hws9SRd8Ue7qr19DRT7dBlxOgVyO89JuMVncTSSwr6GAYTJtg9L9woc4IkGfaxVo3nL90nF9CV5Hncrgr0oUgVk39A9IM4SvdLIVB0I/bEIkaQO2hW5aEZb2c9mRamvSrUs4zZw3H0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727974017; c=relaxed/simple; bh=EwT3q9EsnCa7yrZWUCyRNUjVCTNH45yR8vvcQYT/i1Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WacdB9RxNDrI5s8bxd7ZCO8fMk3AmmB93a27x1z7Ni3Wm8zOXzlL0SA85i7+KkDc2aBoghn1+opdjFLAzfrTIlbZJdvMeldQWo2wigyvr88zNNbLb+dShhvggR+HJwOIiVVgu4w0gmzg4sE2dL7FDqdyy+KLjaWeb8xG3VxYR8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uatXi8xH; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uatXi8xH" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7163489149eso980981a12.1 for ; Thu, 03 Oct 2024 09:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727974015; x=1728578815; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RW5P1Arx8XPYT/NPFqMkITFeiGycXbJcANO3qtPPvbA=; b=uatXi8xHkUqeCRDr5Mlfvk0MQ7i+Nps7epYpKwfgqrQRySXt99qKBhbRaMqzKGY+tS OIILTTs16rkouA4DCwtOCgugHYZ1rF2oUSWAOPqourYu+pstKMN50Zy6PbC5TnxhfXc8 H0P7LVQeSJlpJsVQ6k7sQKEiG+zt7wQAmyeC1x3aH2n4rdeOKOJ/FTSqCmN1aKpRN6VV KfJ6kMjnomN0iZhMexd+6BBmqinzauQsPlsDnPUocmILborbu/Wn3eXu3N9HJhpQykQh GWosPjT/vKjbFLkWvjARTDnbRXScsqHn9e8VnprsXgwtA+/X355H36ntcB+C2fELdeeJ TUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727974015; x=1728578815; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RW5P1Arx8XPYT/NPFqMkITFeiGycXbJcANO3qtPPvbA=; b=j5nH4pOfQ97C7znDQr7VosR1G8eS/1vpKWiDwXdibPtK98teFiVIH+SubM9m1ejf2v 18Vd7FVg2sH7RiDBMPupESl3B9r9HnY6uC4elKQn2NzCkQKNd1OB4FVbVWUwGqQ/zKki YwQMRpDcQg+2oBGibdIQo6qHdi1OFD/fCD2fWXp0SCaFEQZ6T/faSsxfwUByGmEMVUX8 epd6Nx1esLjL3QK/+3UOR6dCHjTGYyOcI4+glKENEI5LCVVF5j2P6JSYBlhpmdrKT0jd 9NT44jaJSaB7RLduMMVxDX3Dpm42r4P6cwbOlMyLwVljLSO5p8QP0PodNM3ICyYZmsY4 ksiA== X-Forwarded-Encrypted: i=1; AJvYcCUPseWBJ0pmaaGPJFPhOyiSWJr5C+iuHxl1iF4Y0F6rSzvJBk8mejFlQBX/qOJYHWUmuqMy9Oo6yHVpWQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyisDW7AzwBfaaZbh9ai2Iytr0T6QQUD9Np+hBwJi7vuW8L845k TZlYl0WVH3Mb5HKveOQPIE9RsKfe/nYKo3t886BM+FT9S6/3e8ltxzLDofrjlZU= X-Google-Smtp-Source: AGHT+IHrNLnq312K7GVWKGT1Vo9Ff69i9ensfXAZGMY12ruPSu/BXqZiVZ26a2jiItIAw0CUa22nFw== X-Received: by 2002:a05:6a20:cf84:b0:1d2:e8f6:81e with SMTP id adf61e73a8af0-1d5db1bf932mr10105522637.24.1727974014772; Thu, 03 Oct 2024 09:46:54 -0700 (PDT) Received: from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9dbcf13b6sm1055380a12.8.2024.10.03.09.46.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 09:46:54 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 09:46:50 -0700 Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c To: Julian Vetter , Arnd Bergmann , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Huacai Chen , WANG Xuerui , Andrew Morton , Geert Uytterhoeven , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, Yann Sionneau References: <20240930132321.2785718-1-jvetter@kalrayinc.com> <20240930132321.2785718-2-jvetter@kalrayinc.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240930132321.2785718-2-jvetter@kalrayinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/30/24 06:23, Julian Vetter wrote: > +void memset_io(volatile void __iomem *dst, int c, size_t count) > +{ > + uintptr_t qc = (u8)c; Missed one change to 'long' > + > + qc |= qc << 8; > + qc |= qc << 16; > + > +#ifdef CONFIG_64BIT > + qc |= qc << 32; > +#endif Could be 'qc *= -1ul / 0xff;' r~