From mboxrd@z Thu Jan 1 00:00:00 1970 From: Khalid Aziz Subject: Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies Date: Thu, 20 Jul 2023 12:48:47 -0600 Message-ID: References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-2-arnd@kernel.org> Reply-To: khalid@gonehiking.org Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NQwSB87aNJbALjnm9C/R6zCaK7ZpPsm12o+o9rxC7b4=; b=vWEgNj+wl2m36K iGt10MOX+WLVNacRi4wz5TShil0PEtLfmBcurR/9ZLOhAW82DC3qIbh4dN3htiZyKp1mRy0m3stBm NVvYCcloyTBSTDwU06hlhIh3cTrXJ7nyCkNp2/nH/qyeFDDJk9I6tSrAz3ZPDaKjju+areF5VCn5u OsM68TkTScJinT++0X972GGUkR8huxv0ov9XLm0BrzJ572MtSrqX4wZARBte3Ee7VniFACWwuLIqq B1UT1+IcZ0UFOnEVfi6r5A0Cxo6u7OXzcjtjLloaTcAHPyeVlTuPTat8YW5pDPoEk2HJeBuFHzTfj hvaFPYLMdC9bGbcyvCaA==; Content-Language: en-US In-Reply-To: <20230719123944.3438363-2-arnd@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller , Javier Martinez Canillas Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Linus Walleij , Matt Turner , Max Filippov , Michael On 7/19/23 6:39 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc codebase, but > the merged arch/powerpc never did > > - arm lists footbridge, integrator and netwinder, but netwinder is actually > part of footbridge, and integrator does not appear to have an actual > VGA hardware, or list it in its ATAG or DT. > > - mips has a few platforms (malta, sibyte, and sni) that initialize > screen_info, on everything else the console is selected but cannot > actually work. > > - csky, hexgagon, loongarch, nios2, riscv and xtensa are not listed > in the opt-out table and declare a screen_info to allow building > vga_con, but this cannot work because the console is never selected. > > Replace this with an opt-in table that lists only the platforms that > remain. This is effectively x86, plus a couple of historic workstation > and server machines that reused parts of the x86 system architecture. > > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Signed-off-by: Arnd Bergmann Reviewed-by: Khalid Aziz > --- > drivers/video/console/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 1b5a319971ed0..6af90db6d2da9 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -7,9 +7,9 @@ menu "Console display driver support" > > config VGA_CONSOLE > bool "VGA text console" if EXPERT || !X86 > - depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \ > - (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ > - !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML > + depends on ALPHA || IA64 || X86 || \ > + (ARM && ARCH_FOOTBRIDGE) || \ > + (MIPS && (MIPS_MALTA || SIBYTE_BCM112X || SIBYTE_SB1250 || SIBYTE_BCM1x80 || SNI_RM)) > select APERTURE_HELPERS if (DRM || FB || VFIO_PCI_CORE) > default y > help