From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Magnus Lindholm <linmag7@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, andi.shyti@kernel.org,
wsa+renesas@sang-engineering.com
Subject: Re: [PATCH] i2c: i2c-elektor: Allow building on SMP kernels
Date: Mon, 24 Nov 2025 23:42:02 +0100 [thread overview]
Message-ID: <b6670aba21de847615cec7534bacce3826e657c9.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2511242045320.36486@angie.orcam.me.uk>
On Mon, 2025-11-24 at 20:49 +0000, Maciej W. Rozycki wrote:
> On Sat, 22 Nov 2025, John Paul Adrian Glaubitz wrote:
>
> > > there has since been some fixes/cleanup work to get rid of cli/sti and
> >
> > s/has/have/
>
> An ambiguity here comes from the mixture of plural and uncountable for
> "fixes" vs "... work".
>
> > > rely on spinlocks instead (as pointed out by Wolfram Sang). Tested this
> >
> > The sentence just ends after "instead". I think you meant to say "instead,
> > let's allow building the driver on SMP kernels again." or something like
> > that.
>
> FWIW I can see nothing wrong with the sentence, "... get rid of cli/sti
> and rely on spinlocks instead." seems like standard English usage to me.
Yes, I was probably misreading it. Either way, I think the v2 looks fine.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2025-11-24 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 12:26 [PATCH] i2c: i2c-elektor: Allow building on SMP kernels Magnus Lindholm
2025-11-22 13:29 ` John Paul Adrian Glaubitz
2025-11-22 13:51 ` Magnus Lindholm
2025-11-24 20:49 ` Maciej W. Rozycki
2025-11-24 22:42 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6670aba21de847615cec7534bacce3826e657c9.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=andi.shyti@kernel.org \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).