From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arnd Bergmann" Subject: Re: [PATCH] alpha: Use generic Date: Wed, 12 Oct 2022 17:32:59 +0200 Message-ID: References: <20220818092059.103884-1-linus.walleij@linaro.org> <20221002224521.GA968453@roeck-us.net> <57200020-c460-74ec-c786-9a2c16f4870e@roeck-us.net> <2e110666-7519-4693-8a89-240cbb118c7e@app.fastmail.com> <20221012140519.GA2405113@roeck-us.net> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1665588801; x=1665675201; bh=p46JJgtAdn om3Y0Add8r9JIUoWNZUEiLnPyZNJRpZL0=; b=grWUM07WK4ujl6DYMF2oCDykzc R2YXZIK+2jB3phTxqA5kFcHsLaChyfa6wFn3WgiZ+UmygkFPRgjvD7Fst/M0TL2v OtUg6YzMEGSjlW1/FFmhkXY4hQLkpXi+uEM8beKFx/cjx3LAV6lFs0Al5Wp+BXez YKFvvL8HcZFOYSpGx+0/9fVBZkUAtIjib7MuBcy5a5ozl4XQrpogbG0fHnIC7+VI s/GLRc+wn5ulBV10Q+ONwn1w7Jxng17EQ4XIP9UWFVcqlpVYXojrW4LIZebij5r6 c9Taq7bJrILbSRkPahh/1hBhPuLbh5fh1wD96rdSG5iH9v+DWXSTIJc5EwYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665588801; x=1665675201; bh=p46JJgtAdnom3Y0Add8r9JIUoWNZ UEiLnPyZNJRpZL0=; b=r8MRYbUFdGX2N0CSQslCsGokunE10rTGgPPhwrQaxasP F1kGKq0kclUrE2MBRyWbvfJ+8Dxzg2sbc45bNIGTCSyewIK8d7yEXz3/qzuEsTSo MQZaNNa8R5rd6XcHHyJdysG5QIvSmq9wypWlIkcYYEoqC1X4nZYccmVu2l298qFg 1B34GqRkkCnpbQX1u/MFq2TblhEVDZVSoEoxJDcbqATPz77766knTBj1SugdjFBx hLrWdVVnHfn3571d31+BZSFnUC/57c1A8pB5Ltn0HdakpuRJmPIGdWFSMBEgFVNG n4cJNb0MPrNHmdJyEw/KA6Y8kHCDi5JsYKC1L7JVFw== In-Reply-To: <20221012140519.GA2405113@roeck-us.net> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: Linus Walleij , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, kernel test robot , Mark Brown , Linux-Arch , regressions@lists.linux.dev On Wed, Oct 12, 2022, at 4:05 PM, Guenter Roeck wrote: > On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote: >> On Tue, Oct 4, 2022, at 9:42 PM, Guenter Roeck wrote: >> > On 10/3/22 06:03, Arnd Bergmann wrote: >> >> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote: >> > >> > Looks like something was missed. When building alpha:allnoconfig >> > in next-20221004: >> > >> > Building alpha:allnoconfig ... failed >> > -------------- >> > Error log: >> > :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] >> > arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for >> > 'marvel_ioread8'; have 'unsigned int(const void *)' >> > 807 | marvel_ioread8(const void __iomem *xaddr) >> > | ^~~~~~~~~~~~~~ >> > In file included from arch/alpha/kernel/core_marvel.c:10: >> > arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration >> > of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned >> > char(const void *)'} >> > 335 | extern u8 marvel_ioread8(const void __iomem *); >> > | ^~~~~~~~~~~~~~ >> >> Right, I already noticed this and uploaded a fixed branch earlier today. >> Should be ok tomorrow. >> > > Unfortunately that did not completely fix the problem, or maybe the fix got > lost. In mainline, when building alpha:allnoconfig: > > arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';', > 'asm' or '__attribute__' before 'marvel_ioread8' > 807 | marvel_ioread8(const void __iomem *xaddr) > > The code is: > > unsigned u8 > marvel_ioread8(const void __iomem *xaddr) > > The compiler doesn't like "unsigned u8". Right, I fixed up a different bug and introduced this wrong type. I didn't catch my mistake until after the pull request was merged, but fixed it in https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=2e21c1575208 which should be in linux-next. I was giving it a little more time to be see if there are any other regressions I caused. Arnd