From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arnd Bergmann" Subject: Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks Date: Fri, 07 Jul 2023 16:32:29 +0200 Message-ID: References: <20230707095415.1449376-1-arnd@kernel.org> <20230707095415.1449376-2-arnd@kernel.org> <87jzvbyh4p.fsf@minerva.mail-host-address-is-not-set> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1688740373; x=1688826773; bh=a8 gC4VrFLmC/qpOerDNkuWSQ8w0qNylgReMLmB5sIDo=; b=d1BcLo8CSCj2vEu4sq FKWaxyR2AN5b8VcvmmiC20KmbyIuYFF8AhTGijC4V0ua412/w5d/qLrDdg933k/f usKCtYCCDApg+v87ENqGQ61nnkWgTQpV1Wb1AGsQvwW/fYJVjzQjLFMkKyeU0YOZ s1hwmXO+RTft+W3JhiO6/m0TZDXug31wMUYR+VQEFI1sdjvIpxgueiDQt3xSFTG/ ttmShmncqLpqp6iGI3twYl2GhLT+c1ex4gsnYzuVSSIvDqPOAgHL6kYFr5CsYUOZ NXbbLWdB7dAVRzLsfKXGFy7iz+vtg7g31z0DEWCa2cKD1agnmQIsieF+WVg0hT8I p6/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688740373; x=1688826773; bh=a8gC4VrFLmC/q pOerDNkuWSQ8w0qNylgReMLmB5sIDo=; b=d/QtLAESgocsLBB4JMrqAXbDtF2bk cDqM0ZS1FhJCAGj2VlmVZJjUbZgnxsZJpQcUu2tSdPq/99Dy3HaXJWYhGCOfNkx9 iuc2++SBlHplnSQHSdZvWdxQ6V2prPQdPcVg1kl6IN5npnoTIiadc3URbqXZh1fQ zFPqbXVCnZz2CxKl82+xr0U79oV3dTYSRtJJFMYOrLFAFlayBYSKB+udQHm/OkHE kBdRJACO/thHsOdY/rloq4gIMHf135R15M9Kt7/wo6CYV7qHAXRsxEnOBuuXWV63 OviduagelG0BPSEovsf162AQOJHo++PWkG7R6JjrnMWuQy8zxDzhlmTbw== In-Reply-To: <87jzvbyh4p.fsf@minerva.mail-host-address-is-not-set> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Javier Martinez Canillas , Arnd Bergmann , Thomas Zimmermann Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , dri-devel@lists.freedesktop.org, Ard Biesheuvel , Helge Deller , Greg Kroah-Hartman , Richard Henderson , Ivan Kokshaysky , Matt Turner , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-al On Fri, Jul 7, 2023, at 15:40, Javier Martinez Canillas wrote: >> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c >> index 5a55ac82c13a4..0c09ff7fde46b 100644 >> --- a/arch/ia64/kernel/setup.c >> +++ b/arch/ia64/kernel/setup.c >> @@ -86,9 +86,11 @@ EXPORT_SYMBOL(local_per_cpu_offset); >> #endif >> unsigned long ia64_cycles_per_usec; >> struct ia64_boot_param *ia64_boot_param; >> +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_EFI) >> struct screen_info screen_info; > > I think that only screen_info should be guarded by both symbols ? > >> unsigned long vga_console_iobase; > > It seems this variable was never used since it was introduced by commit > 66b7f8a30437 ("[IA64-SGI] pcdp: add PCDP pci interface support") ? > >> unsigned long vga_console_membase; > > And this is only used by mdacon (not supported by ia64), vgacon and > vga16fb (not supported by ia64 either). > > So this could just be guarded just by CONFIG_VGA_CONSOLE for ia64 ? Right, I though about doing this more accurately, but in the end went for the simplest change rather than spending much more time trying to clean up the unused variables etc. Let me know if you'd prefer me to respin this part, otherwise I'd call the ia64 bit good enough for the purpose of the series. Arnd