From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Schneider Subject: Re: [patch 08/13] sched: Clenaup PREEMPT_COUNT leftovers Date: Wed, 16 Sep 2020 11:56:23 +0100 Message-ID: References: <20200914204209.256266093@linutronix.de> <20200914204441.794954043@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kjam3xUHxNnLnypt+uwvkSlCnzTbuSoJ7LaDskfH1BA=; b=urZpi7bP8EgINS7PQooLYLRUd +MTKyZoiGKbo/rc0xxerYg0puNFnnBM/JgaHm/tOA3/3DmBv3h9gexakj5E6i7mgAhScBKMIq7WIz BBW1U7g43HD1IVpqNjLesOYsA9c8MJiwxFvpUp99id1gusyc2H2U+fr0GBMympqCgkVdKRvVQRWql 7BB211Fu2ivZg2s31Quhec6Pf4i4OF5XlB4tByD7UD04h4kk/HY6kThMCF/KU+ePuly2oZPQeCtQ6 RSOdc+DRNXPfzQk58J9B3erPs1zU3d1Xk3wcU/N+P8bxWaqdBExPxh9buIW5ndu8S3cKMmzDk/Y6Z luGxXHiMg==; In-reply-to: <20200914204441.794954043@linutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: Thomas Gleixner Cc: Juri Lelli , Peter Zijlstra , Sebastian Andrzej Siewior , Joonas Lahtinen , Lai Jiangshan , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-hexagon@vger.kernel.org, Will Deacon , Ingo Molnar , Anton Ivanov , linux-arch@vger.kernel.org, Vincent Guittot , Brian Cain , Richard Weinberger , Russell King , David Airlie , Ingo Molnar , Geert Uytterhoeven , Mel Gorman , Matt Turner , intel-gfx@lists.freedesktop.org, linux-xtensa@lin On 14/09/20 21:42, Thomas Gleixner wrote: > CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be > removed. Cleanup the leftovers before doing so. > > Signed-off-by: Thomas Gleixner > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Juri Lelli > Cc: Vincent Guittot > Cc: Dietmar Eggemann > Cc: Steven Rostedt > Cc: Ben Segall > Cc: Mel Gorman > Cc: Daniel Bristot de Oliveira Small nit below; Reviewed-by: Valentin Schneider > --- > kernel/sched/core.c | 6 +----- > lib/Kconfig.debug | 1 - > 2 files changed, 1 insertion(+), 6 deletions(-) > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3706,8 +3706,7 @@ asmlinkage __visible void schedule_tail( > * finish_task_switch() for details. > * > * finish_task_switch() will drop rq->lock() and lower preempt_count > - * and the preempt_enable() will end up enabling preemption (on > - * PREEMPT_COUNT kernels). I suppose this wanted to be s/PREEMPT_COUNT/PREEMPT/ in the first place, which ought to be still relevant. > + * and the preempt_enable() will end up enabling preemption. > */ > > rq = finish_task_switch(prev);