From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const. Date: Thu, 21 Jul 2011 21:14:24 +0200 Message-ID: References: <20110610143021.GA26043@linux-mips.org> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110610143021.GA26043@linux-mips.org> (Ralf Baechle's message of "Fri, 10 Jun 2011 15:30:21 +0100") Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-Id: Content-Type: text/plain; charset="macroman" To: Ralf Baechle Cc: Jesse Barnes , linux-pci@vger.kernel.org, Anton Vorontsov , Chris Metcalf , Colin Cross , "David S. Miller" , Eric Miao , Erik Gilling , Guan Xuetao , "H. Peter Anvin" , Imre Kaloz , Ingo Molnar , Ivan Kokshaysky , Lennert Buytenhek , Matt Turner , Nicolas Pitre , Olof Johansson , Paul Mundt , Richard Henderson , Russell King , Thomas Gleixner , Andrew Mor ton , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org Ralf Baechle writes: > Aside of the usual motivation for constification, this function has = a > history of being abused a hook for interrupt and other fixups so I tu= rned > this function const ages ago in the MIPS code but it should be done > treewide. > > Due to function pointer passing in varous places a few other function= s > had to be constified as well. > arch/arm/mach-ixp4xx/avila-pci.c | 2 +- > arch/arm/mach-ixp4xx/coyote-pci.c | 2 +- > arch/arm/mach-ixp4xx/dsmg600-pci.c | 2 +- > arch/arm/mach-ixp4xx/fsg-pci.c | 2 +- > arch/arm/mach-ixp4xx/gateway7001-pci.c | 3 ++- > arch/arm/mach-ixp4xx/goramo_mlr.c | 2 +- > arch/arm/mach-ixp4xx/gtwx5715-pci.c | 2 +- > arch/arm/mach-ixp4xx/ixdp425-pci.c | 2 +- > arch/arm/mach-ixp4xx/ixdpg425-pci.c | 2 +- > arch/arm/mach-ixp4xx/nas100d-pci.c | 2 +- > arch/arm/mach-ixp4xx/nslu2-pci.c | 2 +- > arch/arm/mach-ixp4xx/vulcan-pci.c | 2 +- > arch/arm/mach-ixp4xx/wg302v2-pci.c | 2 +- The IXP4xx part looks good to me. Acked-by: Krzysztof Ha=C5=82asa --=20 Krzysztof Halasa