From: Markus Elfring <Markus.Elfring@web.de>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-rtc@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Yiting Deng <yiting.deng@amlogic.com>
Subject: Re: [PATCH] rtc: amlogic-a4: Optimize global variables
Date: Thu, 17 Jul 2025 17:42:12 +0200 [thread overview]
Message-ID: <045fc0c4-417b-4fd5-8bcf-7c7c34fdb01e@web.de> (raw)
In-Reply-To: <20250717-rtc-regmap-v1-1-ad19736ccb09@amlogic.com>
> Use local variables struct regmap_config instread of global
variable? instead?
> variables. The goal of saving memory has been achieve.
achieved?
You may occasionally put more than 59 characters into text lines
of such a change description.
…
> ---
> Use local variables struct regmap_config instread of global
> variables.
> ---
> drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
…
Please avoid duplicate information here.
Can a summary phrase like “Convert a global variable into a local one
of aml_rtc_probe()” be more appropriate?
Regards,
Markus
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-07-17 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 9:19 [PATCH] rtc: amlogic-a4: Optimize global variables Xianwei Zhao via B4 Relay
2025-07-17 15:42 ` Markus Elfring [this message]
2025-07-21 2:27 ` Xianwei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=045fc0c4-417b-4fd5-8bcf-7c7c34fdb01e@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=xianwei.zhao@amlogic.com \
--cc=yiting.deng@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).