Re: [PATCH v2 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock

[Jian Hu <jian.hu@amlogic.com>]

On 3/14/2026 5:57 PM, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Fri, Mar 13, 2026 at 03:00:21PM +0800, Jian Hu wrote:
>> The mpll3 clock is one parent clock of the sd_emmc and mipi_isp clocks
>> on the Amlogic T7 SoC, but was missing from t7-peripherals-clkc.yaml
>> bindings. Add the mpll3 clock source to the T7 peripherals clock
>> controller input clock list, so that sd_emmc and mipi_isp can use it.
>>
>> For logical consistency, place the required mpll3 entry before the
>> optional entry.
>>
>> This change breaks the ABI, but while the amlogic,t7-peripherals-clkc
>> bindings have been merged upstream, the corresponding DT has not been
>> merged yet. Thus, no real users or systems are affected.
>>
>> Fixes: b4156204e0f5 ("dt-bindings: clock: add Amlogic T7 peripherals clock controller")
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> ---
>>   .../bindings/clock/amlogic,t7-peripherals-clkc.yaml  | 12 ++++++++----
>>   1 file changed, 8 insertions(+), 4 deletions(-)
> This should go for current fixes cycle and your cover letter is silent
> about it, while patchset combines fixes and non-fixes. You clearly don't
> care about maintainers time for deciphering all this.
>
> Well, not my problem.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Thanks for pointing this out, my sincere apologies for the mistake and 
the extra work I've caused you.


I will add the reason for each patch in next cover letter.


I will strictly follow this rule in all future submissions. Again, my 
apologies for the inconvenience.

>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic