From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Conor Dooley <conor@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: interrupt-controller: Add support for Amlogic A4 and A5 SoCsy
Date: Thu, 6 Mar 2025 16:48:00 +0800 [thread overview]
Message-ID: <0dbd6e4f-3d96-40de-953c-48a7eae0e598@amlogic.com> (raw)
In-Reply-To: <20250305-corral-unfair-a7f25abbfd64@spud>
Hi Conor,
Thanks for your advice.
On 2025/3/6 00:28, Conor Dooley wrote:
> On Wed, Mar 05, 2025 at 06:02:56PM +0800, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao<xianwei.zhao@amlogic.com>
>>
>> Update dt-binding document for GPIO interrupt controller
>> of Amlogic A4 and A5 SoCs
>>
>> Signed-off-by: Xianwei Zhao<xianwei.zhao@amlogic.com>
>> ---
>> .../amlogic,meson-gpio-intc.yaml | 21 +++++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>> index a93744763787..3c5853c71efa 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>> @@ -35,6 +35,9 @@ properties:
>> - amlogic,meson-sm1-gpio-intc
>> - amlogic,meson-a1-gpio-intc
>> - amlogic,meson-s4-gpio-intc
>> + - amlogic,a4-gpio-intc
>> + - amlogic,a4-gpio-ao-intc
>> + - amlogic,a5-gpio-intc
>> - amlogic,c3-gpio-intc
>> - amlogic,t7-gpio-intc
>> - const: amlogic,meson-gpio-intc
>> @@ -49,8 +52,6 @@ properties:
>>
>> amlogic,channel-interrupts:
>> description: Array with the upstream hwirq numbers
>> - minItems: 8
>> - maxItems: 12
> Please leave the widest constraints here, and let the more restricted
> ones in your if/else below.
>
Will do.
>> $ref: /schemas/types.yaml#/definitions/uint32-array
>>
>> required:
>> @@ -60,6 +61,22 @@ required:
>> - "#interrupt-cells"
>> - amlogic,channel-interrupts
>>
>> +if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: amlogic,a4-gpio-ao-intc
>> +then:
>> + properties:
>> + amlogic,channel-interrupts:
>> + minItems: 2
>> + maxItems: 12
>> +else:
>> + properties:
>> + amlogic,channel-interrupts:
>> + minItems: 8
>> + maxItems: 12
>> +
>> additionalProperties: false
>>
>> examples:
>>
>> --
>> 2.37.1
>>
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-03-06 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 10:02 [PATCH v3 0/4] Add GPIO interrupt support for Amlogic A4 and A5 SoCs Xianwei Zhao via B4 Relay
2025-03-05 10:02 ` [PATCH v3 1/4] dt-bindings: interrupt-controller: Add " Xianwei Zhao via B4 Relay
2025-03-05 16:28 ` [PATCH v3 1/4] dt-bindings: interrupt-controller: Add support for Amlogic A4 and A5 SoCsy Conor Dooley
2025-03-05 17:07 ` Rob Herring
2025-03-06 8:51 ` Xianwei Zhao
2025-03-06 8:48 ` Xianwei Zhao [this message]
2025-03-05 10:02 ` [PATCH v3 2/4] irqchip: Add support for Amlogic A4 and A5 SoCs Xianwei Zhao via B4 Relay
2025-03-07 8:01 ` Thomas Gleixner
2025-03-07 8:39 ` Xianwei Zhao
2025-03-05 10:02 ` [PATCH v3 3/4] arm64: dts: Add gpio_intc node for Amlogic A4 SoCs Xianwei Zhao via B4 Relay
2025-03-05 10:02 ` [PATCH v3 4/4] arm64: dts: Add gpio_intc node for Amlogic A5 SoCs Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbd6e4f-3d96-40de-953c-48a7eae0e598@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox