From: Neil Armstrong <narmstrong@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>, linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: amlogic: pm-domains: use always-on flag
Date: Wed, 23 Sep 2020 09:50:15 +0200 [thread overview]
Message-ID: <13037590-21c7-5db2-a4c9-e9804c6930ba@baylibre.com> (raw)
In-Reply-To: <20200921222135.7145-1-khilman@baylibre.com>
On 22/09/2020 00:21, Kevin Hilman wrote:
> Rather than use a governor to keep these domains always-on, instead
> use the flag GENPD_FLAG_ALWAYS_ON. This has the same effect, but with
> much lower overhead since the governor path is not used at all.
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/soc/amlogic/meson-ee-pwrc.c | 4 ++--
> drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
> index 43665b77aa9e..a8f18bb17491 100644
> --- a/drivers/soc/amlogic/meson-ee-pwrc.c
> +++ b/drivers/soc/amlogic/meson-ee-pwrc.c
> @@ -433,8 +433,8 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
> if (ret)
> return ret;
>
> - ret = pm_genpd_init(&dom->base, &pm_domain_always_on_gov,
> - false);
> + dom->base.flags = GENPD_FLAG_ALWAYS_ON;
> + ret = pm_genpd_init(&dom->base, NULL, false);
> if (ret)
> return ret;
> } else {
> diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> index 511b6856225d..21b4bc811c00 100644
> --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> @@ -339,8 +339,8 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
> return ret;
> }
>
> - pm_genpd_init(&vpu_pd->genpd, &pm_domain_always_on_gov,
> - powered_off);
> + vpu_pd->genpd.flags = GENPD_FLAG_ALWAYS_ON;
> + pm_genpd_init(&vpu_pd->genpd, NULL, powered_off);
>
> return of_genpd_add_provider_simple(pdev->dev.of_node,
> &vpu_pd->genpd);
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-09-23 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 22:21 [PATCH] soc: amlogic: pm-domains: use always-on flag Kevin Hilman
2020-09-23 7:50 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13037590-21c7-5db2-a4c9-e9804c6930ba@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox