[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[Ben Dooks]

This series adds support for the on SoC RTC driver on the
AMLogic Meson devices. The device-tree updates are not included
as they depend on the reset-controller support in -next.

The series does not have any build dependencies, but does require
the reset controller and device-tree entries for the relevant boards
and has been tested on the ODroid-C1 board.

Changes since V1:
  <1467039135-26588-1-git-send-email-ben.dooks@codethink.co.uk>

 - Fixed checkpatch and sparse errors
 - Fixed minor locking bug when writing static-control register
 - Updated the code ordering in the rtc-meson.c driver
 - Fixed alphanumeric ordering in on-cpu rtc block
 - Added Rob Hering's ack for the DT binding documentation
 - Added better description to the RTC driver header.

Ben Dooks (2):
  rtc: support for amlogic meson rtc
  meson-rtc: add device-tree binding

 .../devicetree/bindings/rtc/rtc-amlogic.txt        |  21 ++
 drivers/rtc/Kconfig                                |   9 +
 drivers/rtc/Makefile                               |   1 +
 drivers/rtc/rtc-meson.c                            | 349 +++++++++++++++++++++
 6 files changed, 392 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt
 create mode 100644 drivers/rtc/rtc-meson.c

-- 
2.8.1

[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[Ben Dooks]

This series adds support for the on SoC RTC driver on the
AMLogic Meson devices. The device-tree updates are not included
as they depend on the reset-controller support in -next.

The series does not have any build dependencies, but does require
the reset controller and device-tree entries for the relevant boards
and has been tested on the ODroid-C1 board.

Thanks to Kevin Hilmand and Neil Armstrong for reviewing the driver.

Changes since V1:
  <1467039135-26588-1-git-send-email-ben.dooks@codethink.co.uk>

 - Fixed checkpatch and sparse errors
 - Fixed minor locking bug when writing static-control register
 - Updated the code ordering in the rtc-meson.c driver
 - Fixed alphanumeric ordering in on-cpu rtc block
 - Added Rob Hering's ack for the DT binding documentation
 - Added better description to the RTC driver header.

Ben Dooks (2):
  rtc: support for amlogic meson rtc
  meson-rtc: add device-tree binding

 .../devicetree/bindings/rtc/rtc-amlogic.txt        |  21 ++
 drivers/rtc/Kconfig                                |   9 +
 drivers/rtc/Makefile                               |   1 +
 drivers/rtc/rtc-meson.c                            | 349 +++++++++++++++++++++
 6 files changed, 392 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt
 create mode 100644 drivers/rtc/rtc-meson.c

-- 
2.8.1

[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[Ben Dooks]

This series adds support for the on SoC RTC driver on the
AMLogic Meson devices. The device-tree updates are not included
as they depend on the reset-controller support in -next.

The series does not have any build dependencies, but does require
the reset controller and device-tree entries for the relevant boards
and has been tested on the ODroid-C1 board.

Changes since V1:
  <1467039135-26588-1-git-send-email-ben.dooks@codethink.co.uk>

 - Fixed checkpatch and sparse errors
 - Fixed minor locking bug when writing static-control register
 - Updated the code ordering in the rtc-meson.c driver
 - Fixed alphanumeric ordering in on-cpu rtc block
 - Added Rob Hering's ack for the DT binding documentation
 - Added better description to the RTC driver header.

Ben Dooks (2):
  rtc: support for amlogic meson rtc
  meson-rtc: add device-tree binding

 .../devicetree/bindings/rtc/rtc-amlogic.txt        |  21 ++
 drivers/rtc/Kconfig                                |   9 +
 drivers/rtc/Makefile                               |   1 +
 drivers/rtc/rtc-meson.c                            | 349 +++++++++++++++++++++
 6 files changed, 392 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt
 create mode 100644 drivers/rtc/rtc-meson.c

-- 
2.8.1

[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[Kevin Hilman]

Ben Dooks <ben.dooks@codethink.co.uk> writes:

> This series adds support for the on SoC RTC driver on the
> AMLogic Meson devices.

-ECONFUSED

In reply to this patch, there are two other "PATCH v3 0/2" replies, an
then the two patches themselves, have "PATCH n/4" subjects when one
would expect "PATCH n/2" subjects.

Might I recommend that you use 'git format-patch --cover-letter
--subject-prefix="PATCH vX"' when formatting your series.  Doing that
will take care of all the numbering for you.

Anyways, I was able to test this version with the DTs from the previous
version, and it works ok.

Can you respin one more time (including the Tested-by) so the RTC
maintainers can pick it up?

Thanks,

Kevin

[PATCH v3 0/2] AMLogic Meson SoC RTC driver

[Ben Dooks]

On 08/07/16 17:20, Kevin Hilman wrote:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
> 
>> This series adds support for the on SoC RTC driver on the
>> AMLogic Meson devices.
> 
> -ECONFUSED
> 
> In reply to this patch, there are two other "PATCH v3 0/2" replies, an
> then the two patches themselves, have "PATCH n/4" subjects when one
> would expect "PATCH n/2" subjects.

This was my mistake of formatting the patch then thinking it would
be easy to remove the other two patches I decided to keep separate
(for reasons below)

> Anyways, I was able to test this version with the DTs from the previous
> version, and it works ok.

Yes, no changes for the DT bits so I decided to remove them as firstly
they depend on the reset-controller changes going in and secondly
the rtc driver part doesn't need them to be there to be able to build.

> Can you respin one more time (including the Tested-by) so the RTC
> maintainers can pick it up?

I'll do that now and try and post them tonight.
Thankyou for testing.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius