Linux-Amlogic Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [RFT net-next v4 5/5] net: stmmac: dwmac-meson8b: propagate rate changes to the parent clock
Date: Mon, 15 Jan 2018 12:50:31 +0100	[thread overview]
Message-ID: <1516017031.2608.17.camel@baylibre.com> (raw)
In-Reply-To: <20180114214858.7217-6-martin.blumenstingl@googlemail.com>

On Sun, 2018-01-14 at 22:48 +0100, Martin Blumenstingl wrote:
> On Meson8b the only valid input clock is MPLL2. The bootloader
> configures that to run at 500002394Hz which cannot be divided evenly
> down to 125MHz using the m250_div clock. Currently the common clock
> framework chooses a m250_div of 2 - with the internal fixed
> "divide by 10" this results in a RGMII TX clock of 125001197Hz (120Hz
> above the requested 125MHz).
> 
> Letting the common clock framework propagate the rate changes up to the
> parent of m250_mux allows us to get the best possible clock rate. With
> this patch the common clock framework calculates a rate of
> very-close-to-250MHz (249999701Hz to be exact) for the MPLL2 clock
> (which is the mux input). Dividing that by 2 (which is an internal,
> fixed divider for the RGMII TX clock) gives us an RGMII TX clock of
> 124999850Hz (which is only 150Hz off the requested 125MHz, compared to
> 1197Hz based on the MPLL2 rate set by u-boot and the Amlogic GPL kernel
> sources).
> 
> SoCs from the Meson GX series are not affected by this change because
> the input clock is FCLK_DIV2 whose rate cannot be changed (which is fine
> since it's running at 1GHz, so it's already a multiple of 250MHz and
> 125MHz).
> 
> Fixes: 566e8251625304 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
> Suggested-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

  reply	other threads:[~2018-01-15 11:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 21:48 [RFT net-next v4 0/5] dwmac-meson8b: clock fixes for Meson8b Martin Blumenstingl
2018-01-14 21:48 ` [RFT net-next v4 1/5] net: stmmac: dwmac-meson8b: only configure the clocks in RGMII mode Martin Blumenstingl
2018-01-15 11:46   ` Jerome Brunet
2018-01-15 12:04     ` Martin Blumenstingl
2018-01-14 21:48 ` [RFT net-next v4 2/5] net: stmmac: dwmac-meson8b: simplify generating the clock names Martin Blumenstingl
2018-01-15 11:46   ` Jerome Brunet
2018-01-15 12:02     ` Martin Blumenstingl
2018-01-15 12:36       ` Jerome Brunet
2018-01-14 21:48 ` [RFT net-next v4 3/5] net: stmmac: dwmac-meson8b: fix internal RGMII clock configuration Martin Blumenstingl
2018-01-15 11:49   ` Jerome Brunet
2018-01-15 12:08     ` Martin Blumenstingl
2018-01-15 12:45       ` Jerome Brunet
     [not found]   ` <CAFBinCDxrxuow-e3aofu6k0ShQdCehVbAJH_u3b26RKN6D0Hug@mail.gmail.com>
2018-01-18 20:05     ` Martin Blumenstingl
2018-01-14 21:48 ` [RFT net-next v4 4/5] net: stmmac: dwmac-meson8b: fix setting the RGMII TX clock on Meson8b Martin Blumenstingl
2018-01-14 21:48 ` [RFT net-next v4 5/5] net: stmmac: dwmac-meson8b: propagate rate changes to the parent clock Martin Blumenstingl
2018-01-15 11:50   ` Jerome Brunet [this message]
2018-01-15 11:45 ` [RFT net-next v4 0/5] dwmac-meson8b: clock fixes for Meson8b Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516017031.2608.17.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox