public inbox for linux-amlogic@lists.infradead.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 u-boot 2/2] reset: add sandbox test for bulk API
Date: Wed, 4 Apr 2018 10:45:22 +0200	[thread overview]
Message-ID: <15fe8854-324c-fa49-c26e-eac86ab84f85@baylibre.com> (raw)
In-Reply-To: <CAPnjgZ0+M8pXpi+YYZReY+hgeXv+XTCDuooxkYYegaXVT_O38w@mail.gmail.com>

On 03/04/2018 19:53, Simon Glass wrote:
> On 3 April 2018 at 17:40, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> This patch adds the bulk reset API tests for the sandbox test suite.
>>
>> Unlike the main test, it also check the "other" reset signal using the bulk API
>> and checks if the resets are correctly asserted/deasserted.
>>
>> To allow the bulk API to work, and avoid changing the DT, the number of resets
>> of the sandbox reset controller has been bumped to 101 for the "other" reset
>> line to be valid.
> 
> Does it need to be 101, or would, say, 5 be enough?

It could stay at 3, but a dts change should be needed since it declares :

resets = <&resetc 100>, <&resetc 2>;
reset-names = "other", "test";

> 
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  arch/sandbox/include/asm/reset.h   |  4 ++++
>>  drivers/reset/sandbox-reset-test.c | 29 +++++++++++++++++++++++++++++
>>  drivers/reset/sandbox-reset.c      |  2 +-
>>  test/dm/reset.c                    | 33 +++++++++++++++++++++++++++++++++
>>  4 files changed, 67 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 

  reply	other threads:[~2018-04-04  8:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  9:40 [PATCH v2 u-boot 0/2] reset: Add get/assert/deassert/release for bulk of reset signals Neil Armstrong
2018-04-03  9:40 ` [PATCH v2 u-boot 1/2] " Neil Armstrong
2018-04-03 17:53   ` Simon Glass
2018-04-11 14:05   ` [U-Boot, v2, u-boot, " Tom Rini
2018-04-14  0:11     ` Marek Vasut
2018-04-14 13:51       ` Tom Rini
2018-04-11 15:49   ` [U-Boot] [PATCH v2 u-boot " Jean-Jacques Hiblot
2018-04-12  8:14     ` Neil Armstrong
2018-04-03  9:40 ` [PATCH v2 u-boot 2/2] reset: add sandbox test for bulk API Neil Armstrong
2018-04-03 17:53   ` Simon Glass
2018-04-04  8:45     ` Neil Armstrong [this message]
2018-04-08 13:56       ` Simon Glass
2018-04-11 14:05   ` [U-Boot,v2,u-boot,2/2] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15fe8854-324c-fa49-c26e-eac86ab84f85@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox