From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D574D6910B for ; Thu, 28 Nov 2024 13:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQ24ClhnrzRuL9EURaw60mR9/saegiNwOO5DAdClPp0=; b=RuKaI5FKFRgOLf DdKpqc97TUKq6xeYa5K6B5S3ieDPKX5riSahZf+Jss5FpApOsGbalqEH8BJGvb/RyG71jXGCn1b9W E8oGA8xr3BKKAF+7woag0DL0ngEML6q6nLkPxB9UVGKWU0qSftiD9YjHjD+uAtoPSs4ljrNSrexh3 IHRmMi6OYv1Lrk1XnEi3Wqd1w6nsGrxAMnkElnxkTEPX0f8uYu65FdJyDM9WrRFKEWJVch3F0Wv/K Ndfa7mNCI/OGgeZG46+c/u9xFN4LtbkBX4GL7dzlcEtrnm6yoOk9x7bc/NuCz0T2wfO1sd4Dln5Qy Skr49VMRopuNmGIgF8fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGef1-0000000FdfA-10sv; Thu, 28 Nov 2024 13:34:23 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGee1-0000000FdZp-31MR for linux-amlogic@lists.infradead.org; Thu, 28 Nov 2024 13:33:24 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-434a852bb6eso7422615e9.3 for ; Thu, 28 Nov 2024 05:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1732800800; x=1733405600; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gmgFSpEV/joPPiUmtOBENMot4M1WgXF/FvOd2XyYmN4=; b=Hxd9jDpGtCj0arg1WXziIGZqsoyLzhUC9lTaH1C4yYRnA+8SW8vaIL2U0DPWT0NS+4 rhMXf20gWTWVsXRA91hZfnFJTS4Hvcz+Zrsk7bWPsWgPIvZeHVvYQKolhpoL3NXzZask Mo3hxV3hpjB6aDHllSPEX+bC+24i7ieL7fB1ylkH00lVaIl1cdGPv6J6n0nn6aPAoVMU 8s3zfaKhkJdOEZnntqDtC16/0KkA1prILDZDgwVkB0XJYa1wnoyEmQ+wyibjFxx3BrCN lpNE7HryY2URuxmTqYwYWi++eJGgFsbg0WImZUcSw9j4Tj1Zb21rt+DZgCxCGOiRp7pc HV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732800800; x=1733405600; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmgFSpEV/joPPiUmtOBENMot4M1WgXF/FvOd2XyYmN4=; b=eQ4VC9BFtqRvhsx8EKw3k+327zLFqFuJOjdb/LmKZv5P6/+pHhi4PmnAcYQAZywv9V OIXoqwpxxR7cH+S4Rt0UFA+U2x8ikw0XMtrhUEQxpdtYuKd0fS/Js/cf4MsnzgdDvCHK quUKHRW2nSbAlEHFLEjh3x4YpMB5qV5FXUMXRTHcsKPXmKko3uv4Ll7NuFfLRdjg9Q/4 wFCGFV79d408bMxYhqmUj2uic1c6P3DEGSmA2+x6kTFemwQ6l2NCgZCfjnjp7/Dwr08o Qm7tPR7Hpi0JKoAWRGyf3GxUj1mJhRSUbCBh6zXS7dnVRP9S6+tlmLeT+RBt1eds+xOT +uqQ== X-Forwarded-Encrypted: i=1; AJvYcCUF6QxFU9aA5/06cjbVcc8oTMwFIIXT7StIIySXgFkEZ8/PDcJKZrSPfGKsxlWumWpWxTMOoB4mLQKlZHVi@lists.infradead.org X-Gm-Message-State: AOJu0YzYHbIUNzkC4qCJOd/f0A/1sArdqDQRQrUTxCUfX7Y6c9IhYmPe tvIEzbqmRmTWW5f5iOVHCC39te5o7pvvLmkaa1pc90PDQOSH3o2O3p4GHFh7tf4C68tvkOT/hJ1 S X-Gm-Gg: ASbGnctm2FAjl/vIAtn0IvDoiif/t7ZrvkzdNz+zkIfPg4q+tPbbAmWH0P3+Tc4caxb cebFLU1NftMVeqr3uOjruNpkDYcu54b97e5Phw0IotMSmzRELZfmUGtGxlwCirJm6NerlK3xNOa x5ZOXzaIESAdFasB9kVXcxonS32rdKxlbCKX02AP5y7TDDppn85+iX/WYb+k4aWNyjMYJQbUnvj Ruzm9KKbu7ArjUOnc8zJ1kG+mqModiH2X3DRSvrdW6lDnfgsA== X-Google-Smtp-Source: AGHT+IGrMdn+38U9uolOFNk+mS2Fm4W0jJARLcSQoHOhr2LuU6616dbNhFwztnrfvkaZnx6NZ9uZrw== X-Received: by 2002:a05:600c:1d8d:b0:434:a902:4168 with SMTP id 5b1f17b1804b1-434a9dd00d3mr68710925e9.18.1732800799856; Thu, 28 Nov 2024 05:33:19 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:b89d:29e9:7047:2d6f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0d9bee2sm22577455e9.1.2024.11.28.05.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 05:33:19 -0800 (PST) From: Jerome Brunet To: "Arnd Bergmann" Cc: "Neil Armstrong" , "Michael Turquette" , "Stephen Boyd" , "Kevin Hilman" , "Martin Blumenstingl" , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Brown" Subject: Re: [PATCH] clk: amlogic: axg-audio: select RESET_MESON_AUX In-Reply-To: (Arnd Bergmann's message of "Wed, 27 Nov 2024 22:23:52 +0100") References: <20241127-clk-audio-fix-rst-missing-v1-1-9f9d0ab98fce@baylibre.com> <12f29978-c8ce-4bee-a447-dcd086eb936d@app.fastmail.com> <1ja5dk2y5l.fsf@starbuckisacylon.baylibre.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 28 Nov 2024 14:33:18 +0100 Message-ID: <1j4j3r32ld.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241128_053322_023541_C471A2F6 X-CRM114-Status: GOOD ( 30.40 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed 27 Nov 2024 at 22:23, "Arnd Bergmann" wrote: > On Wed, Nov 27, 2024, at 21:56, Jerome Brunet wrote: >> On Wed 27 Nov 2024 at 20:30, "Arnd Bergmann" wrote: >>> >>> It looks like RESET_MESON_AUX is a user-visible symbol, >>> so you can simply ask users to turn it on, and add it to >>> the defconfig. >> >> That would work yes but It's really something a user should not be >> concerned with. I can follow-up with another change to remove the user >> visibilty of RESET_MESON_AUX. It is always going to be something >> requested by another driver. > > But that's true for all reset drivers, each one of them is > only useful because it's going to be used by another driver, > same for clk, pinctrl, regulator, ... > All clk, pinctrl or regulator are used by other driver yes, this one as well, sure. What special about this on is that it is an auxiliary bus driver. It is directly instantiated by another driver. That's where it differs. The axg-audio clock driver instantiate the auxiliary reset, it does not use it, which is why it makes sense for it to select the driver. I agree that in such case I should not have added prompt for that symbol. I'd be happy to fix that mistake in the coming cycle. > All other reset drivers are user-visible, with 'default, so for > consistency I think it's best to keep it that way, and > just add a 'default ARCH_MESON' the same way we have for many > other reset drivers: Same consistency remark applies to the clock Kconfig patched here, which select the drivers they directly need and I'd like to keep consistency here too. Also 'default ARCH_MESON' does not accurately reflect when the driver is needed, it will turn on the driver in configuration where it is not necessarily needed, making it more difficult to trim the configuration down without intimate knowledge of the problem. ATM, RESET_MESON_AUX is only needed if COMMON_CLK_AXG_AUDIO is enabled. Isn't it what select is all about ? > > diff --git a/drivers/reset/amlogic/Kconfig b/drivers/reset/amlogic/Kconfig > index 3bee9fd60269..c02edc1b51aa 100644 > --- a/drivers/reset/amlogic/Kconfig > +++ b/drivers/reset/amlogic/Kconfig > @@ -14,6 +14,7 @@ config RESET_MESON > config RESET_MESON_AUX > tristate "Meson Reset Auxiliary Driver" > depends on ARCH_MESON || COMPILE_TEST > + default ARCH_MESON > select AUXILIARY_BUS > select RESET_MESON_COMMON > help > > The only bit that's special here is the exported symbol, > but that is handled by the dependency. > >>> I also see some silliness going on in the >>> include/soc/amlogic/reset-meson-aux.h, which has a >>> non-working 'static inline' definition of the exported >>> function. Before my fix, that would have caused the >>> problem auf a non-working audio driver. >> >> If by 'silliness' you mean there is symbol definition for when >> RESET_MESON_AUX is disabled, indeed I guess that could go away. > > Yes, that's what I meant. > > Arnd -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic