From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1F88CE8341 for ; Mon, 30 Sep 2024 13:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZcW354c4L+fmQZcz2TyeswY+Ed/r4vdFQ0IU9F3K9RY=; b=jTC/ybcbw2QQWM 1YhWkTsNfVU9XrAoJUVz9jI+Ydrdph5xTp77hUaHFZoJE7lRrj9Sg4t+bZF/vjq2FakllJ1aWxnJw 1TDp8Z4JDuPFaq3MzCXAI8rPSOYgESTPN0AX8uowHYVnmVO5W8jKhaVNgKK370e8rczkv1tOEdsnw WNmlpctUacIBwHJx/hMrmusnAKZJJEY1RoUctnoX+NM4Mni5Zr92Ga2eG4jMIBCSjh4okbSkUAitb IyOjThyZ2syFdLKHE9wTalkHO3uuqYY/0qPCzAFBR+vLU867fN3SZWbZRwZhKTjgw6katPW6eHq9O lBCrtyd7eDkxoNZtHb2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svGAm-0000000HDbz-21fQ; Mon, 30 Sep 2024 13:10:44 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svFdD-0000000H4dH-2yCy for linux-amlogic@lists.infradead.org; Mon, 30 Sep 2024 12:36:05 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-42cbbb1727eso38072975e9.2 for ; Mon, 30 Sep 2024 05:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1727699762; x=1728304562; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=TZ9Ka0Ys/+flIMJIlv308swHWJSLUyEk/wV/w9MEUkY=; b=2UGzX9PXtcvcIWKdxMss8r7XRdgWZRUgP8Eo3AS3Vn3qoNIkcdrxelSz3Bn4Kanygm Qn6Oqa62CtWi10wGMUiNm/jRaewgsVDUzqow8rgCkynzfGOBo8nKkRLsjT/PvQkAesFB 1VhkjvSqFkwIEAPSQ/j/IWJ5MFc4kZwmIm+T3hY+dllRBk7YFyjhZvSrmITxum8TxQux KWQhTUelOq6vnuZnmxZzJjVX7wJs/arWsAH+RR+7vhonYXmHV6+Uau1Go2wl2QRjab5U PtWzF6J6nGc2uVNTIYnQDwvDFimUv3s9TzVJD9RU/n43Lac6ZBNsDMofBzq91sQMUTuY DxjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727699762; x=1728304562; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TZ9Ka0Ys/+flIMJIlv308swHWJSLUyEk/wV/w9MEUkY=; b=G0I9Ut5+wpgAAHkqzKOgLJBQxD+E7ZQsPtgj2F08Kfxq31o0C/XY730kKBEAA5HONN gqWGr0yvt/i3A7KRubCNimJICtWwSNK130lqVnkRrnFRq3WH814a8+b8hSZKxf1hWWxd Ets+Ha+4DVEQiOQozVNH36Z7scNKdH3g8YvAMdIO1SGuggFbdGAenfmeUE0KaDRSP5Pn 5J8v1xEToj5kaRlHCWB+heMBiBiJtlc2Y7N3qgeIBEpnGuBAm3f+6v4o5nYT3zBehp3p qhajlywLjQ9cmwm6PCZSwyW4YcUZk07oD0D62vFWJhfp3Dqh4m29UbwfpHheLSymxjSi y9xg== X-Forwarded-Encrypted: i=1; AJvYcCX6xoT9JPZhcM/kz8JQ6NGIFFaSFpYiy6m565t9gIh3tyDDuUPmkzY+LWnj4PrTiYNtAf0XXfHSaHcJ82wG@lists.infradead.org X-Gm-Message-State: AOJu0Ywm+PaudJMVG6fK2x7vV0HKFuU27sI6sfAFqRXQRWrTB70wS9vs DpwjtGIvm1NZOMB+FjYluBOX0b5r1REMtNtaq99hnbQvoQnh28tsbKhpxNrdocM= X-Google-Smtp-Source: AGHT+IGmR7JFFUQuF6lVSWFCy+u7t+yYCBm95s5oHl3xul8GAli/rvg7sRR5FoOz2zLMnPu/hDQ2Yw== X-Received: by 2002:a05:600c:5681:b0:42c:b843:792b with SMTP id 5b1f17b1804b1-42f6b1a2918mr22883345e9.2.1727699761890; Mon, 30 Sep 2024 05:36:01 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:b6ba:bab:ced3:2667]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57dd301dsm102743285e9.8.2024.09.30.05.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 05:36:01 -0700 (PDT) From: Jerome Brunet To: Chuan Liu via B4 Relay Cc: Michael Turquette , Stephen Boyd , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , chuan.liu@amlogic.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] clk: meson: Fix glitch free mux related issues In-Reply-To: <20240929-fix_glitch_free-v1-2-22f9c36b7edf@amlogic.com> (Chuan Liu via's message of "Sun, 29 Sep 2024 14:10:06 +0800") References: <20240929-fix_glitch_free-v1-0-22f9c36b7edf@amlogic.com> <20240929-fix_glitch_free-v1-2-22f9c36b7edf@amlogic.com> Date: Mon, 30 Sep 2024 14:36:00 +0200 Message-ID: <1j8qv9tj2n.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_053603_779031_F40FBDC6 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun 29 Sep 2024 at 14:10, Chuan Liu via B4 Relay wrote: > From: Chuan Liu > > glitch free mux has two clock channels (channel 0 and channel 1) with > the same configuration. When the frequency needs to be changed, the two > channels ping-pong to ensure clock continuity and suppress glitch. > > Channel 0 of glitch free mux is not only the clock source for the mux, > but also the working clock for glitch free mux. Therefore, when glitch > free mux switches, it is necessary to ensure that channel 0 has a clock > input, otherwise glitch free mux will not work and cannot switch to the > target channel. > > Add flag CLK_SET_RATE_GATE to channels 0 and 1 to implement Ping-Pong > switchover to suppress glitch. > > glitch free mux Add flag CLK_OPS_PARENT_ENABLE to ensure that channel 0 > has clock input when switching channels. Several 'glitch_free' are not touched by your change. Why ? I thinking about the mali glitch free mux for example. > > Change-Id: I6fa6ff92f7b2e0a13dd7a27feb0e8568be3ca9f9 > Signed-off-by: Chuan Liu > --- > drivers/clk/meson/a1-peripherals.c | 12 ++++++------ > drivers/clk/meson/axg.c | 16 ++++++++++------ > drivers/clk/meson/c3-peripherals.c | 6 +++--- > drivers/clk/meson/g12a.c | 18 +++++++++++------- > drivers/clk/meson/gxbb.c | 18 +++++++++++------- > drivers/clk/meson/s4-peripherals.c | 32 ++++++++++++++++---------------- > 6 files changed, 57 insertions(+), 45 deletions(-) > > diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c > index 7aa6abb2eb1f..7f515e002adb 100644 > --- a/drivers/clk/meson/a1-peripherals.c > +++ b/drivers/clk/meson/a1-peripherals.c > @@ -423,7 +423,7 @@ static struct clk_regmap dspa_a = { > &dspa_a_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -471,7 +471,7 @@ static struct clk_regmap dspa_b = { > &dspa_b_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -489,7 +489,7 @@ static struct clk_regmap dspa_sel = { > &dspa_b.hw, > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -569,7 +569,7 @@ static struct clk_regmap dspb_a = { > &dspb_a_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -617,7 +617,7 @@ static struct clk_regmap dspb_b = { > &dspb_b_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -635,7 +635,7 @@ static struct clk_regmap dspb_sel = { > &dspb_b.hw, > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c > index 1b08daf579b2..e2d3266f4b45 100644 > --- a/drivers/clk/meson/axg.c > +++ b/drivers/clk/meson/axg.c > @@ -1077,7 +1077,8 @@ static struct clk_regmap axg_vpu_0 = { > * We want to avoid CCF to disable the VPU clock if > * display has been set by Bootloader > */ > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1126,7 +1127,8 @@ static struct clk_regmap axg_vpu_1 = { > * We want to avoid CCF to disable the VPU clock if > * display has been set by Bootloader > */ > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1144,7 +1146,7 @@ static struct clk_regmap axg_vpu = { > &axg_vpu_1.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1194,7 +1196,8 @@ static struct clk_regmap axg_vapb_0 = { > &axg_vapb_0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1242,7 +1245,8 @@ static struct clk_regmap axg_vapb_1 = { > &axg_vapb_1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1260,7 +1264,7 @@ static struct clk_regmap axg_vapb_sel = { > &axg_vapb_1.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > diff --git a/drivers/clk/meson/c3-peripherals.c b/drivers/clk/meson/c3-peripherals.c > index 7dcbf4ebee07..27343a73a521 100644 > --- a/drivers/clk/meson/c3-peripherals.c > +++ b/drivers/clk/meson/c3-peripherals.c > @@ -1364,7 +1364,7 @@ static struct clk_regmap hcodec_0 = { > &hcodec_0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1411,7 +1411,7 @@ static struct clk_regmap hcodec_1 = { > &hcodec_1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1431,7 +1431,7 @@ static struct clk_regmap hcodec = { > .ops = &clk_regmap_mux_ops, > .parent_data = hcodec_parent_data, > .num_parents = ARRAY_SIZE(hcodec_parent_data), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c > index d3539fe9f7af..21a25001e904 100644 > --- a/drivers/clk/meson/g12a.c > +++ b/drivers/clk/meson/g12a.c > @@ -2746,7 +2746,8 @@ static struct clk_regmap g12a_vpu_0 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vpu_0_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -2790,7 +2791,8 @@ static struct clk_regmap g12a_vpu_1 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vpu_1_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -2812,7 +2814,7 @@ static struct clk_regmap g12a_vpu = { > &g12a_vpu_1.hw, > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -3035,7 +3037,8 @@ static struct clk_regmap g12a_vapb_0 = { > &g12a_vapb_0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -3083,7 +3086,8 @@ static struct clk_regmap g12a_vapb_1 = { > &g12a_vapb_1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -3105,7 +3109,7 @@ static struct clk_regmap g12a_vapb_sel = { > &g12a_vapb_1.hw, > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -4039,7 +4043,7 @@ static struct clk_regmap g12a_mali = { > .ops = &clk_regmap_mux_ops, > .parent_hws = g12a_mali_parent_hws, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c > index 262c318edbd5..812b3e20c366 100644 > --- a/drivers/clk/meson/gxbb.c > +++ b/drivers/clk/meson/gxbb.c > @@ -1132,7 +1132,7 @@ static struct clk_regmap gxbb_mali = { > .ops = &clk_regmap_mux_ops, > .parent_hws = gxbb_mali_parent_hws, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1543,7 +1543,8 @@ static struct clk_regmap gxbb_vpu_0 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &gxbb_vpu_0_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1591,7 +1592,8 @@ static struct clk_regmap gxbb_vpu_1 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &gxbb_vpu_1_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1613,7 +1615,7 @@ static struct clk_regmap gxbb_vpu = { > &gxbb_vpu_1.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1674,7 +1676,8 @@ static struct clk_regmap gxbb_vapb_0 = { > &gxbb_vapb_0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1726,7 +1729,8 @@ static struct clk_regmap gxbb_vapb_1 = { > &gxbb_vapb_1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | > + CLK_SET_RATE_GATE, > }, > }; > > @@ -1748,7 +1752,7 @@ static struct clk_regmap gxbb_vapb_sel = { > &gxbb_vapb_1.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_NO_REPARENT, > + .flags = CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c > index c930cf0614a0..cf10be40141d 100644 > --- a/drivers/clk/meson/s4-peripherals.c > +++ b/drivers/clk/meson/s4-peripherals.c > @@ -1404,7 +1404,7 @@ static struct clk_regmap s4_mali_mux = { > .ops = &clk_regmap_mux_ops, > .parent_hws = s4_mali_parent_hws, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1466,7 +1466,7 @@ static struct clk_regmap s4_vdec_p0 = { > &s4_vdec_p0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1516,7 +1516,7 @@ static struct clk_regmap s4_vdec_p1 = { > &s4_vdec_p1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1536,7 +1536,7 @@ static struct clk_regmap s4_vdec_mux = { > .ops = &clk_regmap_mux_ops, > .parent_hws = s4_vdec_mux_parent_hws, > .num_parents = ARRAY_SIZE(s4_vdec_mux_parent_hws), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1586,7 +1586,7 @@ static struct clk_regmap s4_hevcf_p0 = { > &s4_hevcf_p0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1636,7 +1636,7 @@ static struct clk_regmap s4_hevcf_p1 = { > &s4_hevcf_p1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1656,7 +1656,7 @@ static struct clk_regmap s4_hevcf_mux = { > .ops = &clk_regmap_mux_ops, > .parent_hws = s4_hevcf_mux_parent_hws, > .num_parents = ARRAY_SIZE(s4_hevcf_mux_parent_hws), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1712,7 +1712,7 @@ static struct clk_regmap s4_vpu_0 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &s4_vpu_0_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1756,7 +1756,7 @@ static struct clk_regmap s4_vpu_1 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &s4_vpu_1_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1774,7 +1774,7 @@ static struct clk_regmap s4_vpu = { > &s4_vpu_1.hw, > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -1921,7 +1921,7 @@ static struct clk_regmap s4_vpu_clkc_p0 = { > &s4_vpu_clkc_p0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1969,7 +1969,7 @@ static struct clk_regmap s4_vpu_clkc_p1 = { > &s4_vpu_clkc_p1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -1989,7 +1989,7 @@ static struct clk_regmap s4_vpu_clkc_mux = { > .ops = &clk_regmap_mux_ops, > .parent_hws = s4_vpu_mux_parent_hws, > .num_parents = ARRAY_SIZE(s4_vpu_mux_parent_hws), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; > > @@ -2049,7 +2049,7 @@ static struct clk_regmap s4_vapb_0 = { > &s4_vapb_0_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -2097,7 +2097,7 @@ static struct clk_regmap s4_vapb_1 = { > &s4_vapb_1_div.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_SET_RATE_GATE, > }, > }; > > @@ -2115,7 +2115,7 @@ static struct clk_regmap s4_vapb = { > &s4_vapb_1.hw > }, > .num_parents = 2, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > }, > }; -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic