Re: [PATCH V5 3/4] clk: meson: s4: add s4 SoC peripheral clock controller driver and bindings

Yu Tu
2022-11-23T11:22:45Z

On 2022/11/23 18:09, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 23/11/2022 03:13, Yu Tu wrote:
>> Add the peripherals clock controller found and bindings in the s4 SoC family.
>>
>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>> ---
>> .../clock/amlogic,s4-peripherals-clkc.yaml | 105 +
>
> No, this is total mess now.
>
> Additionally, you received a lot of feedback but your changelog says only:
> "V3 -> V4: change format and clock flags."
> so you ignored entire feedback?
>
> That's not the way to work with patches.

Hi Krzysztof,
You can check the previous email reply. Now I don't know who to follow
your advice or Jerome's. I'm confused. Maybe you need to come to a
conclusion. So I can change it in the next patch.

>
> Best regards,
> Krzysztof
>
> .