From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57B21C28B30 for ; Thu, 20 Mar 2025 08:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C0cLENHOm7avZVT1lQEh3ll708xlIPUdYuQc9AxEuRA=; b=OKnUDDcigQEFfo UtR9Du3yL/YgFm/IQ768z2T90KP2297Jwh5fK48ZZFCM98+EQZmyStKXu3LodRfjJ+O0V9NAVCa4p a921kVWFe5naAP/1+O5BFK/B+k/VjM697lpGvBKVwUoL6B1j963g17VOQaXoUn+J9dm/BOeRPpwOF KjZMm+nHO55JghwTsEySKtnNuI5JN+7Sg/jwlVKjIB1oV3nAUhu8XLEWVwXZVQzIZgJycUYKy8yBM 5N6xM+i+ANso/Lc2A2A+tcWpgijXinFSV8/SNfn1587mXi9pAq87hbOPza3vzUnXCAlV8wmkuMjwe /DQZv4B6qOy6d/N79VwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvBZg-0000000Baer-1MAo; Thu, 20 Mar 2025 08:48:24 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvBXy-0000000BaME-2meP for linux-amlogic@lists.infradead.org; Thu, 20 Mar 2025 08:46:39 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4393dc02b78so2385415e9.3 for ; Thu, 20 Mar 2025 01:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1742460397; x=1743065197; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=O3QH3qUlNH/gqSM8rGalO1GesljsIqna87D8tGVSkJw=; b=J707qcSDMUMMz1eaWWC1z3CJyY2YQ6CIeJZ901jDlpssMHpO3R1hTwxRYcBme5Kir3 VnnK6/CFRakTuu0NzzxfS5SSC10OvquFILcOeDdLRtpUzxPhS8FZhXxKz8STW+ENxOoL 4GhrklT1mS7Q8UhiODJjAcGcUOFIEP34YS2VqgFOarPT8hePjtGcs7iBpqOX7K81jkE6 M7RkVG8JUtLeOPE5J+ZAd8EyNsyccOgkENzvbqyWZc0BFnIh3pDIp5DlgJBbUW2xnOb5 tTRrYIge0KoCbXX7GSupwJbsoqj4frttAc1dOLWgzStxpcE/G4aCave3+XJ6HGxFnDrN y+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742460397; x=1743065197; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O3QH3qUlNH/gqSM8rGalO1GesljsIqna87D8tGVSkJw=; b=XFDHbwX0jTKf5+TmQq2ysCONDFpy+uqDmeK1y/n8YJUTtMDIHjbBLbF/z3hxvAz44d 8S5CtUAo6g4XA7/R8ddNFhjBeyWqJkRdmSPLEBNj+oBuZISDJnIvth9cZUmUYYQK1Ljs XGXl1xkC4FhOZO8Zooh/dr6qk7PFD7RhRDK+ldh2u21BBY0SCmoIrfXwy7q0H9gAv5Fg jtq/FRuAMQsAguGgfHk4yodbpxE39EiDff54uU/d06+Sm8PgQpY2P7KT05Xrhyb7i6oi sF3OGgDGj+dv6/zOi+OOqwjQUw8kDe1dFvKzE34wQJCOmRuMTfuLWKKAeAYd3N6hYUn6 rKQQ== X-Forwarded-Encrypted: i=1; AJvYcCXdg7r/wXBIE21lycveLJRg23wbn86egJ6oe/KpxbdgR9K4J6c4oCKbaI6cokYh37dQRdUsmc1EtruReGVB@lists.infradead.org X-Gm-Message-State: AOJu0Yw59aL9cN5N3wWH1AOLOw8acN4yx+feyJxXNzil1dVN3gX9WpqI wKqTd0ZDMr0GX++3/czSvqq2wfjneBz0lQwhZs6nMdR7vjrUOExQCw+Nqxf5tU0= X-Gm-Gg: ASbGncs7AITkpG0PdMXONK+fdGJBqQA3TWMe/PiXxufApcEe52QO3zIoCsT7XGgPZsc f3JSYtCHX+CzyxCIaveyZO9fovMusGYbGncspuTUizTT8jiWHHJ9Fv0lxBDQCT1rwbX63rMtUrN D9GWZKM99T5D8l2WtXSE5HTKbNbRzRp5rpb4A0GK8PpJjOU25Uk+ZbUH8typlqe6GfLn0HtvGnB 4WOu8OVC+qyBkXrc/mrJRnmfIwbTDxmVeJMKRmICQdHSaGatxGzPmUAp3gLbdSElonsgm7oXT+6 LjjqwqEqM59O/H+7BCOuXH+2lUzfRg0yBxpygFyYMv3h X-Google-Smtp-Source: AGHT+IHQm6xIAgW16c9rSJQfuwSOkpxhl2OJe1D/zAy21xgweiekDmWGRfU5wzJOyEV/LHZraSbP0g== X-Received: by 2002:a05:600c:3b20:b0:43c:fd1b:d6d6 with SMTP id 5b1f17b1804b1-43d43842e8bmr48409055e9.31.1742460396893; Thu, 20 Mar 2025 01:46:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:e0ba:db2b:7cf4:d967]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb318afbsm23804353f8f.72.2025.03.20.01.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 01:46:36 -0700 (PDT) From: Jerome Brunet To: jiebing chen via B4 Relay Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , jiebing.chen@amlogic.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com Subject: Re: [PATCH v4 4/6] ASoC: meson: g12a-toacodec: Add s4 tocodec driver In-Reply-To: <20250319-audio_drvier-v4-4-686867fad719@amlogic.com> (jiebing chen via's message of "Wed, 19 Mar 2025 15:04:47 +0800") References: <20250319-audio_drvier-v4-0-686867fad719@amlogic.com> <20250319-audio_drvier-v4-4-686867fad719@amlogic.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Thu, 20 Mar 2025 09:46:36 +0100 Message-ID: <1jfrj82ioj.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250320_014638_697663_3C172850 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed 19 Mar 2025 at 15:04, jiebing chen via B4 Relay wrote: > From: jiebing chen > > S4 tocodec support 8 lane to input, It need to enable > bclk and mclk control bit when work > > Signed-off-by: jiebing chen > --- > sound/soc/meson/g12a-toacodec.c | 46 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c > index 531bb8707a3ec4c47814d6a0676d5c62c705da75..88f9adabb3b5d7d8881fa110f1d0d51e9ac9c60e 100644 > --- a/sound/soc/meson/g12a-toacodec.c > +++ b/sound/soc/meson/g12a-toacodec.c > @@ -41,6 +41,9 @@ > #define CTRL0_BCLK_SEL_LSB 4 > #define CTRL0_MCLK_SEL GENMASK(2, 0) > > +#define CTRL0_BCLK_ENABLE_SHIFT 30 > +#define CTRL0_MCLK_ENABLE_SHIFT 29 > + > #define TOACODEC_OUT_CHMAX 2 > > struct g12a_toacodec { > @@ -129,6 +132,10 @@ static const struct snd_kcontrol_new g12a_toacodec_out_enable = > SOC_DAPM_SINGLE_AUTODISABLE("Switch", TOACODEC_CTRL0, > CTRL0_ENABLE_SHIFT, 1, 0); > > +static const struct snd_kcontrol_new s4_toacodec_clk_enable = > + SOC_DAPM_DOUBLE("Switch", TOACODEC_CTRL0, > + CTRL0_BCLK_ENABLE_SHIFT, CTRL0_MCLK_ENABLE_SHIFT, 1, 0); > + I think I remember commenting on this already. > static const struct snd_soc_dapm_widget g12a_toacodec_widgets[] = { > SND_SOC_DAPM_MUX("SRC", SND_SOC_NOPM, 0, 0, > &g12a_toacodec_mux), > @@ -143,6 +150,19 @@ static const struct snd_soc_dapm_widget sm1_toacodec_widgets[] = { > &g12a_toacodec_out_enable), > }; > > +/* > + * FIXME: > + * On this soc, tocodec need enable mclk and bclk control > + * just enable it when dapm power widget power on. > + */ > + > +static const struct snd_soc_dapm_widget s4_toacodec_widgets[] = { > + SND_SOC_DAPM_MUX("SRC", TOACODEC_CTRL0, CTRL0_BCLK_ENABLE_SHIFT, 0, > + &sm1_toacodec_mux), > + SND_SOC_DAPM_SWITCH("OUT EN", TOACODEC_CTRL0, CTRL0_MCLK_ENABLE_SHIFT, 0, > + &g12a_toacodec_out_enable), > +}; > + > static int g12a_toacodec_input_hw_params(struct snd_pcm_substream *substream, > struct snd_pcm_hw_params *params, > struct snd_soc_dai *dai) > @@ -236,6 +256,10 @@ static const struct snd_kcontrol_new sm1_toacodec_controls[] = { > SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0), > }; > > +static const struct snd_kcontrol_new s4_toacodec_controls[] = { > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 7, 0), > +}; > + > static const struct snd_soc_component_driver g12a_toacodec_component_drv = { > .probe = g12a_toacodec_component_probe, > .controls = g12a_toacodec_controls, > @@ -258,6 +282,17 @@ static const struct snd_soc_component_driver sm1_toacodec_component_drv = { > .endianness = 1, > }; > > +static const struct snd_soc_component_driver s4_toacodec_component_drv = { > + .probe = sm1_toacodec_component_probe, > + .controls = s4_toacodec_controls, > + .num_controls = ARRAY_SIZE(s4_toacodec_controls), > + .dapm_widgets = s4_toacodec_widgets, > + .num_dapm_widgets = ARRAY_SIZE(s4_toacodec_widgets), > + .dapm_routes = g12a_toacodec_routes, > + .num_dapm_routes = ARRAY_SIZE(g12a_toacodec_routes), > + .endianness = 1, > +}; > + > static const struct regmap_config g12a_toacodec_regmap_cfg = { > .reg_bits = 32, > .val_bits = 32, > @@ -278,6 +313,13 @@ static const struct g12a_toacodec_match_data sm1_toacodec_match_data = { > .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6), > }; > > +static const struct g12a_toacodec_match_data s4_toacodec_match_data = { > + .component_drv = &s4_toacodec_component_drv, > + .field_dat_sel = REG_FIELD(TOACODEC_CTRL0, 19, 20), > + .field_lrclk_sel = REG_FIELD(TOACODEC_CTRL0, 12, 14), > + .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6), > +}; > + > static const struct of_device_id g12a_toacodec_of_match[] = { > { > .compatible = "amlogic,g12a-toacodec", > @@ -287,6 +329,10 @@ static const struct of_device_id g12a_toacodec_of_match[] = { > .compatible = "amlogic,sm1-toacodec", > .data = &sm1_toacodec_match_data, > }, > + { > + .compatible = "amlogic,s4-toacodec", > + .data = &s4_toacodec_match_data, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, g12a_toacodec_of_match); -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic