From: Jerome Brunet <jbrunet@baylibre.com>
To: Alexander Stein <alexander.stein@mailbox.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property
Date: Sat, 15 Jan 2022 16:04:10 +0100 [thread overview]
Message-ID: <1jilulav4u.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220115093557.30498-1-alexander.stein@mailbox.org>
On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@mailbox.org> wrote:
> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required
> property. Add it.
Binginds *mandates* ?? the bindings you are adding mandates that, not the
previous doc, nor the driver.
Modifying drivers and DT to accomodate made-up bindings requirement is
disturbing.
The bindings should not require that because the driver does not, as it
stands. The driver requires the arb reset to be provided, not the name.
Please fix the bindings.
>
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> This is essentially a preparation for YAML conversion to fix the
> warnings.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3f5254eeb47b..b14175e2f1d6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 {
> interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_A>;
> resets = <&arb AXG_ARB_TODDR_A>;
> + reset-names = "arb";
> amlogic,fifo-depth = <512>;
> status = "disabled";
> };
> @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 {
> interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_B>;
> resets = <&arb AXG_ARB_TODDR_B>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 {
> interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_C>;
> resets = <&arb AXG_ARB_TODDR_C>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 {
> interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_A>;
> resets = <&arb AXG_ARB_FRDDR_A>;
> + reset-names = "arb";
> amlogic,fifo-depth = <512>;
> status = "disabled";
> };
> @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 {
> interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_B>;
> resets = <&arb AXG_ARB_FRDDR_B>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 {
> interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_C>;
> resets = <&arb AXG_ARB_FRDDR_C>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-01-15 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 9:35 [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Alexander Stein
2022-01-15 9:35 ` [PATCH 2/2] ASoC: meson: axg-fifo: convert Amlogic FIFO controller to yaml Alexander Stein
2022-01-15 15:16 ` Jerome Brunet
2022-01-15 17:22 ` Rob Herring
2022-01-15 17:29 ` Rob Herring
2022-01-15 15:04 ` Jerome Brunet [this message]
2022-01-16 9:49 ` [PATCH 1/2] arm64: dts: meson-axg: add missing reset-names property Alexander Stein
2022-01-16 17:30 ` Jerome Brunet
2022-01-17 9:49 ` Neil Armstrong
2022-01-17 10:08 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jilulav4u.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alexander.stein@mailbox.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox