From: Jerome Brunet <jbrunet@baylibre.com>
To: Alexander Stein <alexander.stein@mailbox.org>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property
Date: Mon, 25 Oct 2021 17:53:04 +0200 [thread overview]
Message-ID: <1jilxl5ang.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20211023214856.30097-1-alexander.stein@mailbox.org>
On Sat 23 Oct 2021 at 23:48, Alexander Stein <alexander.stein@mailbox.org> wrote:
> Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
> do not match any of the regexes: 'pinctrl-[0-9]+'"
>
> Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
Hey Alexander,
First, thanks for picking this up.
I think Rob's automated reply is because you forgot to update the
example (if the property is required, it should be there)
Also, I believe this change could have been sent separately, to Marc
(instead of Cc) and with the "ASoC" prefix.
With this changed
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> I am aware that adding required properties to bindings is frowned upon. But in
> this case it seems acceptable for the following reasons:
> * AVDD-supply was used from the very first driver commit
> * All DT (g12 and gxl) using t9015 controller provide AVDD-supply
> already
> But I'm ok to not add it to required properties as well. The driver uses
> it nevertheless though.
>
> Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> index c7613ea728d4..5f4e25ab5af6 100644
> --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> @@ -34,6 +34,10 @@ properties:
> resets:
> maxItems: 1
>
> + AVDD-supply:
> + description:
> + Analogue power supply.
> +
> required:
> - "#sound-dai-cells"
> - compatible
> @@ -41,6 +45,7 @@ required:
> - clocks
> - clock-names
> - resets
> + - AVDD-supply
>
> additionalProperties: false
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-10-25 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 21:48 [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Alexander Stein
2021-10-23 21:48 ` [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent Alexander Stein
2021-10-26 7:27 ` Neil Armstrong
2021-10-26 16:21 ` Alexander Stein
2021-10-23 21:48 ` [PATCH 3/4] arm64: dts: amlogic: meson-g12: Fix GPU operating point table node name Alexander Stein
2021-10-25 8:19 ` Neil Armstrong
2021-10-23 21:48 ` [PATCH 4/4] arm64: dts: amlogic: Fix SPI NOR flash node name for ODROID N2/N2+ Alexander Stein
2021-10-25 8:20 ` Neil Armstrong
2021-10-24 14:27 ` [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Rob Herring
2021-10-25 9:44 ` Mark Brown
2021-10-25 15:53 ` Jerome Brunet [this message]
2021-10-26 16:30 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jilxl5ang.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alexander.stein@mailbox.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox