From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 797F4C63797 for ; Mon, 16 Jan 2023 13:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HJZ/et+Ul4vY2/bASdjV+wTl3fYmjy1+I/YBWk5tm/k=; b=fbRjCUmAX0Bdoz H+uO6mLVAdKWo2j+rs2GMMPn/8XXSOnAn5Ixg42xKSyp5kLR9XOu2dvi0DXf/wTmD4zbbmPD5itvz ydhs15N7m6mq4TDvKaGmXwXo25YHroAg7SsJ6jpnbAdZuPjGYm+doBov3DoCCiC+ww4yYSDAViKUN o0Hvyf41lcfYxee5xjPuDaLp27gadZm2FyCBhOYk03dC3J5xgVbUPYHy/KR7a4xSGaFAljsrpeEfk FDK1vaoBBWQE9y2VrQhkAEoP9sA559BLqTIDvLsoLqBkp7EpHxWaO+6rwWQySaKQOKcHLQyFx2ZKI V3dlpTGCbIHLdd6B1ujA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPie-00AVmQ-3a; Mon, 16 Jan 2023 13:40:12 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPby-00ASZl-2M for linux-amlogic@lists.infradead.org; Mon, 16 Jan 2023 13:33:24 +0000 Received: by mail-wm1-x32e.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so3973906wml.0 for ; Mon, 16 Jan 2023 05:33:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=vNvOX7djjjBjKEHmE27QSb/utZxm3kNjauubSDkICIY=; b=6bhtEiB/26w40qL9HaO/mVd9X3p8jy6vR7QeqGrPRJ9VB4cbhqVmYX8lVFCN97bDp8 +SwI6iuAHzjQLzrGzQdusMA6GrMJ5o4ITzzzqlWBSXyBsu96TRSSoTiYjuDKjfoEIQTl UOJLQioaei3BPtjjyn1U51LZtT64WFjP9YS1Uz6XnRV7A9TBSxPARRUB5iUO58JFaAaa VHJfn12xJ5HIT8jyQD6neJWmA+Sr7sVm3iU4xnZi3JOxzzOBH/F4ZzRVmL8SSVUeuVy0 /O1ujgi0twVfWd0t7dgMSPfB2CpWz+cngGXWzdcdt96kJ7AIAb9UlnOVcDmlcxb7bsap GJRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vNvOX7djjjBjKEHmE27QSb/utZxm3kNjauubSDkICIY=; b=wnUAaKg+ZZfqZBNAwDkyjlVpBOFQPr0GLwRRr5u7GwL31DnzJXfEg3YmbCRu0jBCsU oBtXJl10A40SmaPJeCBdkJiZXbaQrU9Gph6cNJJl67uecXQ/DKv9i4gRMcFkn+FFuzRy ywhYDwzZEmsI28Xj1HpN0YsE+v5L/RhyTCRH1yc4OmTzJem2EVyor6CvqFt0676chdhD I31Dw24M/dHH+hIVik3THR5Z3m7x8yfcxqe3g2fzQgxYTiQMHrQH0yd7mhrIGoNJ/OL0 AQ1Q+zkMmwQ7aq5KPWpp+fuEayVy3ChAHW+RO4jQNHuyini+Y4ExmwS5BcHuncN/C7m0 xdgg== X-Gm-Message-State: AFqh2krbBE5xFFNEgyzUjm8N43zyR+oK3FSAha1sz5Lewk3Mc5dq0v7n T9TyXITafbGhFbLui6NdPkjiYQ== X-Google-Smtp-Source: AMrXdXs7Udt0PVl+BdLhxYFkzaWgm2loEFFrkTgEVgK1GDAx8n6smMRhZQAkQmlOxiad+c7F5VlOMw== X-Received: by 2002:a05:600c:4d23:b0:3da:270b:ba6b with SMTP id u35-20020a05600c4d2300b003da270bba6bmr9967300wmp.41.1673875992502; Mon, 16 Jan 2023 05:33:12 -0800 (PST) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id d6-20020a05600c3ac600b003da0dc39872sm16227317wms.6.2023.01.16.05.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 05:33:12 -0800 (PST) References: <20230116091637.272923-1-jbrunet@baylibre.com> <20230116091637.272923-3-jbrunet@baylibre.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Jerome Brunet To: Simon Horman Cc: netdev@vger.kernel.org, "David S. Miller" , linux-amlogic@lists.infradead.org, Kevin Hilman , Neil Armstrong , Da Xue , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Date: Mon, 16 Jan 2023 14:27:57 +0100 In-reply-to: Message-ID: <1jk01mhaeg.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_053318_152704_F82D22B7 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon 16 Jan 2023 at 13:11, Simon Horman wrote: > On Mon, Jan 16, 2023 at 10:16:36AM +0100, Jerome Brunet wrote: >> Add support for the mdio mux and internal phy glue of the GXL SoC >> family >> >> Signed-off-by: Jerome Brunet >> --- >> drivers/net/mdio/Kconfig | 11 ++ >> drivers/net/mdio/Makefile | 1 + >> drivers/net/mdio/mdio-mux-meson-gxl.c | 160 ++++++++++++++++++++++++++ >> 3 files changed, 172 insertions(+) >> create mode 100644 drivers/net/mdio/mdio-mux-meson-gxl.c > > Hi Jerome, > > please run this patch through checkpatch. Shame ... I really thought I did, but I forgot indeed. I am really sorry for this. I'll fix everything. > > ... > >> diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c >> new file mode 100644 >> index 000000000000..205095d845ea >> --- /dev/null >> +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c > > ... > >> +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) >> +{ > > nit: I think void would be a more appropriate return type for this > function. Likewise gxl_enable_external_mdio() > > ... > >> +static int gxl_mdio_mux_probe(struct platform_device *pdev){ > > nit: '{' should be at the beginning of a new line > >> + struct device *dev = &pdev->dev; >> + struct clk *rclk; >> + struct gxl_mdio_mux *priv; > > nit: reverse xmas tree for local variable declarations. > >> + int ret; >> + >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; > > nit: may be it is nicer to use dev_err_probe() here for consistency. That was on purpose. I only use the `dev_err_probe()` when the probe may defer, which I don't expect here. I don't mind changing if you prefer it this way. > >> + platform_set_drvdata(pdev, priv); >> + >> + priv->regs = devm_platform_ioremap_resource(pdev, 0); >> + if (IS_ERR(priv->regs)) >> + return PTR_ERR(priv->regs); > > And here. > > ... _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic