From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F270D3B7F3 for ; Tue, 9 Dec 2025 10:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QyGcpw601POd1yeziDzZYJ9qdFBFUZTId5lUhuBJVBg=; b=tkB5LCAo1hAIpl tIuw0g1XQ8A67UToZbRHNNBQxePYGRR+4GqCDR+98ww9TE3SzJ9R3sopeH/b+aDxFN8mQLjVGvn6k g8kqbBPeu3z7NHtE/p/+BEXS8YAcnGcisNeTzyizbmjcsp96PjgKoM9XPFuorwotyIw5jO1fFR4QW Z4lta0rFVV6xr4p4++BvCGeGSaiB4ht40CnvC+PEm4q6Sq81bl8xU9EGxwP0wfnT1AktnsQfTBdTE 4norapveaUWhQnU0Imc1D0qpYL4vutPqlr46XtzAWceAwKvctfjh38jF1DCDF/NtpcOw9VZDJPtJf vT8VciSsHsH6uwNc/xrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSumC-0000000E5hO-1v8P; Tue, 09 Dec 2025 10:17:00 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSum7-0000000E5gQ-33DO for linux-amlogic@lists.infradead.org; Tue, 09 Dec 2025 10:16:58 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42e2b80ab25so2215187f8f.1 for ; Tue, 09 Dec 2025 02:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765275413; x=1765880213; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7jqYN1k2sIIVDynNkGogy0+4dYc363N58InYK+olTwA=; b=GLXW8iPHDYxdzDoJsh0rS2n4wtm89TT9jshfn82U4uf4j2796IaLj8gzQo9gDwG6Kj VEUs+chQK2kdg7E49aZhSRmhL8I44q0FuCq8E/s/v5DMF82OKukBGUveHou/XMvJNKk+ m6zyuI80bYRtkDr27NWNNB1388pRjDtsuuiGvT8rkpMfKY3GnaN6Ql/Dg61knPhQ5dZy 3N6hhaVaSmi2jgAaU7nhSTp0jOiRxMpC2noxLonpXKZRTzWeeATt13uiXSdyzayM1cND nlAL/Ql9lzLuJZWk8R423D858hGZeg++fY9Ta8oqt1EQKtivEbTi+0k/Fbw8eaImLjk/ goVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765275413; x=1765880213; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7jqYN1k2sIIVDynNkGogy0+4dYc363N58InYK+olTwA=; b=tyr6eSAymWsRoFSE3OIiUmvHRqxtTIwYZUAgV+p62ISid+0RY1qJVnRGe8fZcxHvxl apva+S5E7Ogcl75qZ6QBWS4nk6vHnv9i6ICubt8RjrFZI4ZeSLeB7LkirNFKkgplcaqT mk0MxdzOsaUfz1QFkSUsoX08f342jGN7Pr7+ebSrsorB+F6jEHiqjT23lewqj/2mGRtD e6y2KHPdiSQxyp6SLsC+9+J8hVkqvLsOIi7cYnp5MXgiYAm/CFgF484GRw8jT6XuNv5R Upn5e7RVp+BcbixoKZVGQYfPZx4cv9UQYJG7iHrfYPLL9T563/VnEwd5F6faLCxcP4Z+ pySQ== X-Forwarded-Encrypted: i=1; AJvYcCWUA21DhIktMmyTKf1x3f8EkHpGoOQGFXIVr4zmq0Sc0q5D/whxjwo3or9ua/jUUb1XJya0+bAjAvPAeOzn@lists.infradead.org X-Gm-Message-State: AOJu0YzPHtnp8o7CicE/nMuQPGOY/UiNlZNIFXtYglT2w8DRDu7Upnkf 5iY+p3ayoMRn7Z2+gHmkect8MuOQHuLAEhxmhZw8ndPuuVeYyGHnID5hGpxVezlM//E= X-Gm-Gg: ASbGncsuNQa1FvrgW/kMxyqoGqb5/MDEbqWhKx8Zsm3GBAdvXVBI8v2cPSic/9jacDW NnMchlGkTYJAdBWFaR6d4lUqo5nXpRG+ZY9/Fw8bEaw3nn9PWGNdKS635THDi1ZvYto/2BqoY0U X9RJP8we4RNwo4tT/R6gyUyqR/tYBftP68g3p7FbqIyDKhfZvfmhDHJdxASXqZq4jRT4ysnW7r0 uPwCr2dqSiNVW7gFTqEbqBA+kmvYrGC1SJQS0ofp8BhNNvSAIF4/upvu4KfRia4kzP3W/Bkhggq 2biJMjGj2o1XU4IFJGVOz8c8WJ+YbC/dTae4LkFQpRDF9SuNgb28zr96jiOe3axj4TiyJdgDEle She3oADgAAYY4McWV9QUXAikSwIP2jL41XvCtpohnJxvgVzX02T4oPF5LAJT0SLGeuNiijPhcIF k+zH1ili+ssQ== X-Google-Smtp-Source: AGHT+IGYLG3rhZdJLL1r2IWmCryy/+X0jCUOg6jWuDZZCpYYA9nn3V/pWnZyhAXTJz8/W4BJn1NtMw== X-Received: by 2002:a5d:42c4:0:b0:42f:9e8d:548 with SMTP id ffacd0b85a97d-42f9e8d1ee0mr1375634f8f.60.1765275413393; Tue, 09 Dec 2025 02:16:53 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:f9ab:1ddd:a971:a17b]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7cbe9032sm28891327f8f.1.2025.12.09.02.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 02:16:52 -0800 (PST) From: Jerome Brunet To: Krzysztof Kozlowski Cc: Jian Hu , Xianwei Zhao , Chuan Liu , Neil Armstrong , Kevin Hilman , Stephen Boyd , Michael Turquette , robh+dt , Rob Herring , devicetree , linux-clk , linux-amlogic , linux-kernel , linux-arm-kernel Subject: Re: [PATCH v6 2/5] dt-bindings: clock: add Amlogic T7 SCMI clock controller In-Reply-To: <4f5ec838-f8d6-4c3b-94f2-b2a60cfe64ec@kernel.org> (Krzysztof Kozlowski's message of "Tue, 9 Dec 2025 07:01:44 +0100") References: <20251204053635.1234150-1-jian.hu@amlogic.com> <20251204053635.1234150-3-jian.hu@amlogic.com> <20251208-independent-warping-macaw-74a169@quoll> <4f5ec838-f8d6-4c3b-94f2-b2a60cfe64ec@kernel.org> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 09 Dec 2025 11:16:52 +0100 Message-ID: <1jy0ncvu23.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251209_021656_024100_5938A73E X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue 09 Dec 2025 at 07:01, Krzysztof Kozlowski wrote: > On 08/12/2025 09:40, Jian Hu wrote: >> Hi, Krzysztof >> >> >> Thans for your review. >> >> On 12/8/2025 2:17 PM, Krzysztof Kozlowski wrote: >>> [ EXTERNAL EMAIL ] >>> >>> On Thu, Dec 04, 2025 at 01:36:31PM +0800, Jian Hu wrote: >>>> Add DT bindings for the SCMI clock controller of the Amlogic T7 SoC family. >>>> >>>> Signed-off-by: Jian Hu >>>> Acked-by: Rob Herring (Arm) >>>> --- >>>> include/dt-bindings/clock/amlogic,t7-scmi.h | 47 +++++++++++++++++++++ >>>> 1 file changed, 47 insertions(+) >>>> create mode 100644 include/dt-bindings/clock/amlogic,t7-scmi.h >>>> >>> Where is any binding doc for this? Why is this a separate patch? >> >> >> The ARM SCMI device tree binding specification is located at >> ./Documentation/devicetree/bindings/firmware/arm,scmi.yaml. > > Then git grep for the file name - there is no such compatible. Are you > sure you follow writing bindings doc? > > Think how are you going to use these values. You will have phandle, yes? > To some controller, yes? Which one? For the C3 (I believe the T7 is the same), the compatible being used is "arm,scmi-smc". It is a generic one documented here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml?h=v6.18#n202 The phandle used is a subnode of that, to clock protocol: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi?h=v6.18#n116 Same things is done on imx, stm and rockchip platforms from what I can see. Jian is just adding the arbitrary IDs used to identify the clocks in the FW. I don't think there is anything out of the ordirnary here. Is there something else Rob and I missed reviewing this ? > >> >> Certain secure clocks on the T7 rely on the ARM SCMI driver stack, which >> is officially supported by ARM. >> >> The kernel-side SCMI client implementation resides in >> ./drivers/firmware/arm_scmi/. >> >> To enable ARM SCMI on T7, three components are needed: >> >> - Kernel-side definition of ARM SCMI clock indices (this patch addresses >> this component); >> - SCMI server implementation in the ARM Trusted Firmware (ATF) running >> at Exception Level 3 (EL3), which has been integrated into the bootloader; >> - Device Tree Source (DTS) configuration for ARM SCMI clock nodes (the >> DTS changes will be submitted after the T7 clock driver patches are >> merged upstream). > > So silently you keep the users hidden? No, I want to see the users. > Is there a new requirement to submit the DTS file changes along with the driver changes now ? This has never been case before, especially since the changes are merged through different trees. > > Best regards, > Krzysztof -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic