From: stefan@agner.ch (Stefan Agner)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 4/5] mfd: rn5t618: register power off callback optionally
Date: Tue, 28 Jun 2016 22:53:21 -0700 [thread overview]
Message-ID: <20160629055322.23038-5-stefan@agner.ch> (raw)
In-Reply-To: <20160629055322.23038-1-stefan@agner.ch>
Only register power off if the PMIC is defined as system power
controller (see Documentation/devicetree/bindings/power/
power-controller.txt).
Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/rn5t618.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index c86160d..1831740 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -102,9 +102,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
return ret;
}
- if (!pm_power_off) {
- rn5t618_pm_power_off = priv;
- pm_power_off = rn5t618_power_off;
+ if (of_device_is_system_power_controller(i2c->dev.of_node)) {
+ if (!pm_power_off) {
+ rn5t618_pm_power_off = priv;
+ pm_power_off = rn5t618_power_off;
+ } else {
+ dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
+ }
}
return 0;
--
2.9.0
next prev parent reply other threads:[~2016-06-29 5:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 5:53 [PATCH v5 0/5] regulator: add Ricoh RN5T567 PMIC support Stefan Agner
2016-06-29 5:53 ` [PATCH v5 1/5] ARM: dts: meson: minix-neo-x8: define PMIC as power controller Stefan Agner
2016-06-29 5:53 ` [PATCH v5 2/5] mfd: add Ricoh RN5T567 PMIC support Stefan Agner
2016-06-29 5:53 ` [PATCH v5 3/5] regulator: rn5t618: add " Stefan Agner
2016-06-29 5:53 ` Stefan Agner [this message]
2016-06-29 5:53 ` [PATCH v5 5/5] mfd: rn5t618: register restart handler Stefan Agner
2016-06-29 18:05 ` Applied "mfd: rn5t618: Register restart handler" to the regulator tree Mark Brown
2016-06-29 8:12 ` [PATCH v5 0/5] regulator: add Ricoh RN5T567 PMIC support Lee Jones
2016-06-29 8:15 ` Stefan Agner
2016-06-29 16:25 ` [GIT PULL] Immutable branch between MFD, Regulator and ARM for v4.8 Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629055322.23038-5-stefan@agner.ch \
--to=stefan@agner.ch \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).