linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 0/2] AMLogic Meson SoC RTC driver
Date: Tue, 12 Jul 2016 19:23:43 +0200	[thread overview]
Message-ID: <20160712172343.GV22202@piout.net> (raw)
In-Reply-To: <1468343799-12844-1-git-send-email-ben.dooks@codethink.co.uk>

Well, I hoped I could send my review before v4 but I was a bit too
late...

On 12/07/2016 at 18:16:37 +0100, Ben Dooks wrote :
> This series adds support for the on SoC RTC driver on the
> AMLogic Meson devices. The device-tree updates are not included
> as they depend on the reset-controller support in -next.
> 
> The series does not have any build dependencies, but does require
> the reset controller and device-tree entries for the device-tree
> files for the relevant boards. 
> 
> The series tested by myself on the ODroid-C1 board with a battery
> pack attached. It has also been tested by Kevin Hilman.
> 
> I will send the DT changes in a second series so that they can be
> merged once the dependencies have been satisified.
> 
> Changes since V3:
>   <1467748122-14833-1-git-send-email-ben.dooks@codethink.co.uk>
> - Added Kevin's tested by
> 
> Changes since V1:
>   <1467039135-26588-1-git-send-email-ben.dooks@codethink.co.uk>
> 
>  - Fixed checkpatch and sparse errors
>  - Fixed minor locking bug when writing static-control register
>  - Updated the code ordering in the rtc-meson.c driver
>  - Fixed alphanumeric ordering in on-cpu rtc block
>  - Added Rob Hering's ack for the DT binding documentation
>  - Added better description to the RTC driver header.
> 
> Ben Dooks (2):
>   rtc: support for amlogic meson rtc
>   meson-rtc: add device-tree binding
> 
>  .../devicetree/bindings/rtc/rtc-amlogic.txt        |  21 ++
>  drivers/rtc/Kconfig                                |   9 +
>  drivers/rtc/Makefile                               |   1 +
>  drivers/rtc/rtc-meson.c                            | 349 +++++++++++++++++++++
>  4 files changed, 380 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt
>  create mode 100644 drivers/rtc/rtc-meson.c
> 
> -- 
> 2.8.1
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2016-07-12 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 17:16 [PATCH v4 0/2] AMLogic Meson SoC RTC driver Ben Dooks
2016-07-12 17:16 ` [PATCH v4 1/2] rtc: support for amlogic meson rtc Ben Dooks
2016-07-12 17:16 ` [PATCH v4 2/2] meson-rtc: add device-tree binding Ben Dooks
2016-07-12 17:23 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712172343.GV22202@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).