* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
@ 2016-10-19 19:49 Javier Martinez Canillas
2016-10-20 16:23 ` Kevin Hilman
2016-10-20 22:28 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-10-19 19:49 UTC (permalink / raw)
To: linus-amlogic
The Amlogic Meson is a DT-only platform, which means the devices are
registered via OF and not using the legacy platform devices support.
So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
since the reported uevent MODALIAS to user-space will be the OF one.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/watchdog/meson_gxbb_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
index 44d180a2c5e5..45d47664a00a 100644
--- a/drivers/watchdog/meson_gxbb_wdt.c
+++ b/drivers/watchdog/meson_gxbb_wdt.c
@@ -264,7 +264,6 @@ static struct platform_driver meson_gxbb_wdt_driver = {
module_platform_driver(meson_gxbb_wdt_driver);
-MODULE_ALIAS("platform:meson-gxbb-wdt");
MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
MODULE_DESCRIPTION("Amlogic Meson GXBB Watchdog timer driver");
MODULE_LICENSE("Dual BSD/GPL");
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
2016-10-19 19:49 [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas
@ 2016-10-20 16:23 ` Kevin Hilman
2016-10-20 22:28 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2016-10-20 16:23 UTC (permalink / raw)
To: linus-amlogic
Javier Martinez Canillas <javier@osg.samsung.com> writes:
> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
>
> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
> since the reported uevent MODALIAS to user-space will be the OF one.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
>
> drivers/watchdog/meson_gxbb_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
> index 44d180a2c5e5..45d47664a00a 100644
> --- a/drivers/watchdog/meson_gxbb_wdt.c
> +++ b/drivers/watchdog/meson_gxbb_wdt.c
> @@ -264,7 +264,6 @@ static struct platform_driver meson_gxbb_wdt_driver = {
>
> module_platform_driver(meson_gxbb_wdt_driver);
>
> -MODULE_ALIAS("platform:meson-gxbb-wdt");
> MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
> MODULE_DESCRIPTION("Amlogic Meson GXBB Watchdog timer driver");
> MODULE_LICENSE("Dual BSD/GPL");
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
2016-10-19 19:49 [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas
2016-10-20 16:23 ` Kevin Hilman
@ 2016-10-20 22:28 ` Guenter Roeck
2016-11-29 14:57 ` Javier Martinez Canillas
1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2016-10-20 22:28 UTC (permalink / raw)
To: linus-amlogic
On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
>
> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
> since the reported uevent MODALIAS to user-space will be the OF one.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
2016-10-20 22:28 ` Guenter Roeck
@ 2016-11-29 14:57 ` Javier Martinez Canillas
2016-11-30 10:59 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-11-29 14:57 UTC (permalink / raw)
To: linus-amlogic
Hello Wim,
On 10/20/2016 07:28 PM, Guenter Roeck wrote:
> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>> The Amlogic Meson is a DT-only platform, which means the devices are
>> registered via OF and not using the legacy platform devices support.
>>
>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>> since the reported uevent MODALIAS to user-space will be the OF one.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Any comments about this patch? There are other two similar fixes for
watchdog drivers that were also reviewed by Guenter but never picked:
https://lkml.org/lkml/2016/10/14/412
https://lkml.org/lkml/2016/10/14/413
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
2016-11-29 14:57 ` Javier Martinez Canillas
@ 2016-11-30 10:59 ` Guenter Roeck
2016-11-30 12:41 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2016-11-30 10:59 UTC (permalink / raw)
To: linus-amlogic
On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote:
> Hello Wim,
>
> On 10/20/2016 07:28 PM, Guenter Roeck wrote:
>> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>>> The Amlogic Meson is a DT-only platform, which means the devices are
>>> registered via OF and not using the legacy platform devices support.
>>>
>>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>>> since the reported uevent MODALIAS to user-space will be the OF one.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>
> Any comments about this patch? There are other two similar fixes for
> watchdog drivers that were also reviewed by Guenter but never picked:
>
> https://lkml.org/lkml/2016/10/14/412
> https://lkml.org/lkml/2016/10/14/413
>
> Best regards,
>
The patches are all in my watchdog-next branch, so Wim will hopefully
pick them up for the next release.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
2016-11-30 10:59 ` Guenter Roeck
@ 2016-11-30 12:41 ` Javier Martinez Canillas
0 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-11-30 12:41 UTC (permalink / raw)
To: linus-amlogic
Hello Guenter,
On 11/30/2016 07:59 AM, Guenter Roeck wrote:
> On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote:
>> Hello Wim,
>>
>> On 10/20/2016 07:28 PM, Guenter Roeck wrote:
>>> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>>>> The Amlogic Meson is a DT-only platform, which means the devices are
>>>> registered via OF and not using the legacy platform devices support.
>>>>
>>>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>>>> since the reported uevent MODALIAS to user-space will be the OF one.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>
>> Any comments about this patch? There are other two similar fixes for
>> watchdog drivers that were also reviewed by Guenter but never picked:
>>
>> https://lkml.org/lkml/2016/10/14/412
>> https://lkml.org/lkml/2016/10/14/413
>>
>> Best regards,
>>
> The patches are all in my watchdog-next branch, so Wim will hopefully
> pick them up for the next release.
>
Great, thanks a lot for the info.
> Guenter
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-30 12:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 19:49 [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas
2016-10-20 16:23 ` Kevin Hilman
2016-10-20 22:28 ` Guenter Roeck
2016-11-29 14:57 ` Javier Martinez Canillas
2016-11-30 10:59 ` Guenter Roeck
2016-11-30 12:41 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).