From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 21 Oct 2016 17:54:08 +0200 Subject: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection In-Reply-To: <1477060838-14164-9-git-send-email-narmstrong@baylibre.com> References: <1477060838-14164-1-git-send-email-narmstrong@baylibre.com> <1477060838-14164-9-git-send-email-narmstrong@baylibre.com> Message-ID: <20161021155408.GR16974@lunn.ch> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Fri, Oct 21, 2016 at 04:40:33PM +0200, Neil Armstrong wrote: > The Meson GXL dwmac Glue Layer also provides switching between an external PHY > and an internal RMII 10/100 PHY. > Add a way to setup the correct PHY switching from a device tree attribute. Humm, actually. Maybe PHY_IS_INTERNAL in the phydrv->flags is the better solution. The MAC can then use phy_is_internal(ndev->phydev) to decide if this register needs programming. Andrew