From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 20 Jan 2017 18:46:58 +0100 Subject: [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO In-Reply-To: References: <20170120132650.9784-1-martin.blumenstingl@googlemail.com> <20170120152232.13943-1-martin.blumenstingl@googlemail.com> <20170120152232.13943-3-martin.blumenstingl@googlemail.com> <20170120162138.GE25907@lunn.ch> Message-ID: <20170120174658.GG25907@lunn.ch> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote: > I though that this is good practice - the documentation doesn't say > that it should only be added in specific cases: [0] Agreed, the text should be better, listing when it is appropriate to use. > my intention behind adding the PHY ID was to make it easier to see > which devices uses which PHY. this is especially useful for devices > with RTL8211F PHY (basically all devices with RGMII PHY except the > P200) as these may need similar fixes than [1] I would not say it is wrong to list the PHY ID, it just has consequences if the PHY ever changes. Andrew