linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dlan@gentoo.org (Yixun Lan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 6/6] serial: meson: change interrupt description to tty name
Date: Thu, 27 Apr 2017 14:13:07 +0800	[thread overview]
Message-ID: <20170427061307.GA1416@cubie> (raw)
In-Reply-To: <e2b3ef2d-dfe4-de91-c8e1-4046fc2ebdb5@gmail.com>

On 22:18 Wed 19 Apr     , Heiner Kallweit wrote:
> Change interrupt description from driver name to tty name
> (e.g. ttyAML0). If multiple serial ports are enabled this
> allows to determine which interrupt belongs to which port
> in /proc/interrupts.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - use new port->name instead of of node name
> ---
>  drivers/tty/serial/meson_uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 171eb673..082e038e 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -295,7 +295,7 @@ static int meson_uart_startup(struct uart_port *port)
>  	writel(val, port->membase + AML_UART_MISC);
>  
>  	ret = request_irq(port->irq, meson_uart_interrupt, 0,
> -			  meson_uart_type(port), port);
> +			  port->name, port);
>  
>  	return ret;
>  }
> -- 
> 2.12.2
> 
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

Hi Heiner Kallweit:

there is no member of 'name' in 'struct uart_port'
or did I miss something obviously?
(btw, I'm applying these patches on top of khilman's tree: branch v4.12/integ)

as I got this error:

drivers/tty/serial/meson_uart.c: In function ?meson_uart_startup?:                
drivers/tty/serial/meson_uart.c:298:10: error: ?struct uart_port? has no
member named ?name?
      port->name, port);                         
          ^~                                                              
make[3]: *** [scripts/Makefile.build:294: drivers/tty/serial/meson_uart.o] Error 1
make[3]: *** Waiting for unfinished jobs....  

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55

      reply	other threads:[~2017-04-27  6:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 19:59 [PATCH v2 0/6] serial: meson: series with smaller fixes and improvements Heiner Kallweit
2017-04-19 20:17 ` [PATCH v2 1/6] serial: meson: fix setting number of stop bits Heiner Kallweit
2017-04-19 20:17 ` [PATCH v2 2/6] serial: meson: remove dead code in meson_uart_change_speed Heiner Kallweit
2017-04-19 20:17 ` [PATCH v2 3/6] serial: meson: remove unneeded variable assignment in meson_serial_port_write Heiner Kallweit
2017-04-19 20:17 ` [PATCH v2 4/6] serial: meson: make use of uart_port member mapsize Heiner Kallweit
2017-04-19 20:17 ` [PATCH v2 5/6] serial: meson: remove use of flag UPF_IOREMAP Heiner Kallweit
2017-04-19 20:18 ` [PATCH v2 6/6] serial: meson: change interrupt description to tty name Heiner Kallweit
2017-04-27  6:13   ` Yixun Lan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427061307.GA1416@cubie \
    --to=dlan@gentoo.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).