linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq
Date: Mon, 20 Nov 2017 11:14:15 +0530	[thread overview]
Message-ID: <20171120054415.GC6125@vireshk-i7> (raw)
In-Reply-To: <d8fc48bacf7cc153d806e10bc39ab507534f4691.1510997223.git.arvind.yadav.cs@gmail.com>

On 18-11-17, 15:03, Arvind Yadav wrote:
> platform_get_irq() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> 
>  drivers/mmc/host/sdhci-spear.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index 8c0f884..900838b 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
>  	host->hw_name = "sdhci";
>  	host->ops = &sdhci_pltfm_ops;
>  	host->irq = platform_get_irq(pdev, 0);
> +	if (host->irq <= 0) {
> +		ret = host->irq;
> +		goto err_host;
> +	}
>  	host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
>  
>  	sdhci = sdhci_priv(host);

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

  reply	other threads:[~2017-11-20  5:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  9:33 [PATCH 1/6 v2] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-18  9:33 ` [PATCH 2/6 v2] mmc: s3cmci: " Arvind Yadav
2017-11-18  9:33 ` [PATCH 3/6 v2] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-18  9:33 ` [PATCH 4/6 v2] mmc: sdhci-spear: " Arvind Yadav
2017-11-20  5:44   ` Viresh Kumar [this message]
2017-11-20  6:45     ` Arvind Yadav
2017-11-18  9:33 ` [PATCH 5/6 v2] mmc: sh_mmcif: " Arvind Yadav
2017-11-18  9:33 ` [PATCH 6/6 v2] mmc: sunxi-mmc: " Arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120054415.GC6125@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).