linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree
Date: Sat, 10 Feb 2018 10:19:05 +0100	[thread overview]
Message-ID: <20180210091911.3644-1-marcus.folkesson@gmail.com> (raw)

watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.

Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/watchdog/sama5d4_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
index 0ae947c3d7bc..e6c679383734 100644
--- a/drivers/watchdog/sama5d4_wdt.c
+++ b/drivers/watchdog/sama5d4_wdt.c
@@ -33,7 +33,7 @@ struct sama5d4_wdt {
 	unsigned long		last_ping;
 };
 
-static int wdt_timeout = WDT_DEFAULT_TIMEOUT;
+static int wdt_timeout;
 static bool nowayout = WATCHDOG_NOWAYOUT;
 
 module_param(wdt_timeout, int, 0);
@@ -212,7 +212,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	wdd = &wdt->wdd;
-	wdd->timeout = wdt_timeout;
+	wdd->timeout = WDT_DEFAULT_TIMEOUT;
 	wdd->info = &sama5d4_wdt_info;
 	wdd->ops = &sama5d4_wdt_ops;
 	wdd->min_timeout = MIN_WDT_TIMEOUT;
-- 
2.15.1

             reply	other threads:[~2018-02-10  9:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10  9:19 Marcus Folkesson [this message]
2018-02-10  9:19 ` [PATCH v2 2/7] watchdog: sunxi: allow setting timeout in devicetree Marcus Folkesson
2018-02-10  9:19 ` [PATCH v2 3/7] watchdog: sirfsoc: " Marcus Folkesson
2018-02-10  9:19 ` [PATCH v2 4/7] watchdog: pnx4008: make use of timeout-secs provided " Marcus Folkesson
2018-02-10  9:19 ` [PATCH v2 5/7] watchdog: mtk: allow setting timeout " Marcus Folkesson
2018-02-10 11:10   ` Sean Wang
2018-02-10 12:43     ` Marcus Folkesson
2018-02-10 20:12       ` Marcus Folkesson
2018-02-11  1:52         ` Guenter Roeck
2018-02-11  7:46           ` Sean Wang
2018-02-11 11:17             ` Guenter Roeck
2018-02-10  9:19 ` [PATCH v2 6/7] watchdog: meson: " Marcus Folkesson
2018-02-10  9:19 ` [PATCH v2 7/7] watchdog: coh901327: make use of timeout-secs provided " Marcus Folkesson
2018-02-11 17:33   ` [v2, " Guenter Roeck
2018-02-22 14:00   ` [PATCH v2 " Linus Walleij
2018-02-10 14:29 ` [PATCH v2 1/7] watchdog: sama5d4: " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180210091911.3644-1-marcus.folkesson@gmail.com \
    --to=marcus.folkesson@gmail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).