From: marcus.folkesson@gmail.com (Marcus Folkesson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 2/7] watchdog: sunxi: allow setting timeout in devicetree
Date: Sun, 11 Feb 2018 21:08:42 +0100 [thread overview]
Message-ID: <20180211200847.25000-2-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <20180211200847.25000-1-marcus.folkesson@gmail.com>
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt | 4 ++++
drivers/watchdog/sunxi_wdt.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
index 62dd5baad70e..49900e72f6b1 100644
--- a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
@@ -6,9 +6,13 @@ Required properties:
"allwinner,sun6i-a31-wdt"
- reg : Specifies base physical address and size of the registers.
+Optional properties:
+- timeout-sec : Contains the watchdog timeout in seconds
+
Example:
wdt: watchdog at 1c20c90 {
compatible = "allwinner,sun4i-a10-wdt";
reg = <0x01c20c90 0x10>;
+ timeout-sec = <10>;
};
diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c
index 9728fa32c357..55f166bec0ca 100644
--- a/drivers/watchdog/sunxi_wdt.c
+++ b/drivers/watchdog/sunxi_wdt.c
@@ -39,7 +39,7 @@
#define DRV_VERSION "1.0"
static bool nowayout = WATCHDOG_NOWAYOUT;
-static unsigned int timeout = WDT_MAX_TIMEOUT;
+static unsigned int timeout;
/*
* This structure stores the register offsets for different variants
--
2.15.1
next prev parent reply other threads:[~2018-02-11 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 20:08 [PATCH v3 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree Marcus Folkesson
2018-02-11 20:08 ` Marcus Folkesson [this message]
2018-02-19 0:06 ` [PATCH v3 2/7] watchdog: sunxi: allow setting timeout " Rob Herring
2018-02-19 3:01 ` Chen-Yu Tsai
2018-02-11 20:08 ` [PATCH v3 3/7] watchdog: sirfsoc: " Marcus Folkesson
2018-02-19 0:07 ` Rob Herring
2018-02-19 1:07 ` Guenter Roeck
2018-02-22 0:02 ` Rob Herring
2018-02-11 20:08 ` [PATCH v3 4/7] watchdog: pnx4008: make use of timeout-secs provided " Marcus Folkesson
2018-02-11 20:08 ` [PATCH v3 5/7] watchdog: mtk: allow setting timeout " Marcus Folkesson
2018-02-19 0:08 ` Rob Herring
2018-02-19 1:08 ` Guenter Roeck
2018-02-19 17:02 ` Matthias Brugger
2018-02-11 20:08 ` [PATCH v3 6/7] watchdog: meson: " Marcus Folkesson
2018-02-11 20:08 ` [PATCH v3 7/7] watchdog: coh901327: make use of timeout-secs provided " Marcus Folkesson
2018-02-12 1:11 ` [v3, " Guenter Roeck
2018-02-22 14:01 ` [PATCH v3 " Linus Walleij
2018-02-12 1:10 ` [v3, 1/7] watchdog: sama5d4: " Guenter Roeck
2018-02-12 8:59 ` [PATCH v3 " Nicolas Ferre
2018-03-16 13:37 ` Marcus Folkesson
2018-03-17 1:56 ` Guenter Roeck
2018-03-17 8:37 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211200847.25000-2-marcus.folkesson@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).