public inbox for linux-amlogic@lists.infradead.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: linus-amlogic@lists.infradead.org
Subject: [RFC usb-next v3 1/2] usb: core: split usb_phy_roothub_{init,alloc}
Date: Tue, 27 Mar 2018 11:00:04 +0200	[thread overview]
Message-ID: <20180327090004.GA6649@kroah.com> (raw)
In-Reply-To: <05b749dc-c8e6-260f-287d-7b3e8f599d13@ti.com>

On Tue, Mar 27, 2018 at 11:24:08AM +0300, Roger Quadros wrote:
> On 26/03/18 23:38, Martin Blumenstingl wrote:
> > Before this patch usb_phy_roothub_init served two purposes (from a
> > caller's point of view - like hcd.c):
> > - parsing the PHYs and allocating the list entries
> > - calling phy_init on each list entry
> > 
> > While this worked so far it has one disadvantage: if we need to call
> > phy_init for each PHY instance then the existing code cannot be re-used.
> > Solve this by splitting off usb_phy_roothub_alloc which only parses the
> > PHYs and allocates the list entries.
> > usb_phy_roothub_init then gets a struct usb_phy_roothub and only calls
> > phy_init on each PHY instance (along with the corresponding cleanup if
> > that failed somewhere).
> > 
> > This is a preparation step for adding proper suspend support for some
> > hardware that requires phy_exit to be called during suspend and phy_init
> > to be called during resume.
> > 
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> I don't think we need RFC in subject.

As I don't apply series with RFC in the subject, that might be a good
idea :)

  reply	other threads:[~2018-03-27  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 20:38 [RFC usb-next v3 0/2] fix HCD PHY suspend handling Martin Blumenstingl
2018-03-26 20:38 ` [RFC usb-next v3 1/2] usb: core: split usb_phy_roothub_{init,alloc} Martin Blumenstingl
2018-03-27  3:19   ` Chunfeng Yun
2018-03-27  8:24   ` Roger Quadros
2018-03-27  9:00     ` Greg KH [this message]
2018-03-26 20:38 ` [RFC usb-next v3 2/2] usb: core: use phy_exit during suspend if wake up is not supported Martin Blumenstingl
2018-03-27  3:20   ` Chunfeng Yun
2018-03-27  8:24   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327090004.GA6649@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox