Linux-Amlogic Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: martin.blumenstingl@googlemail.com (Martin Blumenstingl)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 0/1] fix OOB size decoding on SK Hynix H27UCG8T2BTR
Date: Sun, 24 Jun 2018 22:53:54 +0200	[thread overview]
Message-ID: <20180624205355.20060-1-martin.blumenstingl@googlemail.com> (raw)

The OOB size of the SK Hynix H27UCG8T2BTR is currently detected to be
640 bytes, while the datasheet states that it should be 1280 bytes.

I only have one single device with a SK Hynix NAND flash, so I cannot
say whether this fix may or may not break other chips. other datasheets
I have checked:
- H27UBG8T2B uses a page size of 8KiB -> not applicable
- H27UBG8T2A also uses a page size of 8KiB -> not applicable either

so I would appreciate if someone else could confirm (even if it's
"just" by looking at a datasheet) that this patch should work for other
SK Hynix NAND chips with 16KiB page size.

I decided not to add a "Fixes" tag because it seems H27UCG8T2BTR was
not supported properly at any point in the past (upstream at least).


changes since v1 at [0]:
- don't apply the fix for all Hynix chips with 16KiB page size as
  suggested by Miquel Raynal
- added an inline comment what the new logic is supposed to do
- I asked Hynix for feedback on my initial patch, unfortunately it
  seems that they cannot disclose any information from the datasheets
  publicly


[0] https://patchwork.ozlabs.org/cover/916836/


Martin Blumenstingl (1):
  mtd: rawnand: hynix: fix decoding the OOB size on H27UCG8T2BTR

 drivers/mtd/nand/raw/nand_hynix.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.18.0

             reply	other threads:[~2018-06-24 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 20:53 Martin Blumenstingl [this message]
2018-06-24 20:53 ` [PATCH v2 1/1] mtd: rawnand: hynix: fix decoding the OOB size on H27UCG8T2BTR Martin Blumenstingl
2018-06-24 21:03   ` Boris Brezillon
2018-06-24 21:16     ` Martin Blumenstingl
2018-06-25 12:38 ` [PATCH v2 0/1] fix OOB size decoding on SK Hynix H27UCG8T2BTR Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180624205355.20060-1-martin.blumenstingl@googlemail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox