From mboxrd@z Thu Jan 1 00:00:00 1970 From: fengguang.wu@intel.com (kbuild test robot) Date: Tue, 14 Aug 2018 19:45:18 +0800 Subject: [PATCH] PCI: meson: fix ptr_ret.cocci warnings In-Reply-To: <1534227522-186798-3-git-send-email-hanjie.lin@amlogic.com> References: <1534227522-186798-3-git-send-email-hanjie.lin@amlogic.com> Message-ID: <20180814114518.GA82641@lkp-ib04> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org From: kbuild test robot drivers/pci/controller/dwc/pci-meson.c:121:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: b43bb00f7533 ("PCI: meson: add the Amlogic Meson PCIe controller driver") CC: Yue Wang Signed-off-by: kbuild test robot --- pci-meson.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -118,10 +118,7 @@ static int meson_pcie_get_mem(struct pla return -ENODEV; mp->mem_res.cfg_base = devm_ioremap_resource(dev, res); - if (IS_ERR(mp->mem_res.cfg_base)) - return PTR_ERR(mp->mem_res.cfg_base); - - return 0; + return PTR_ERR_OR_ZERO(mp->mem_res.cfg_base); } static int meson_pcie_init_clk(struct meson_pcie *mp)