From: yangxuan8282@gmail.com (He Yangxuan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1
Date: Fri, 9 Nov 2018 18:07:01 +0800 [thread overview]
Message-ID: <20181109100701.62vxl4wdgm5lwn36@raspberrypi> (raw)
In-Reply-To: <bfe5d8b7-fabc-dec1-2798-8922f3a69350@baylibre.com>
On Fri, Nov 09, 2018 at 10:47:37AM +0100, Neil Armstrong wrote:
> Hi,
>
> On 05/11/2018 18:29, He Yangxuan wrote:
> > This patch adds support for the Phicomm N1. This device based on P230 reference design.
> > The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
> > And this box doesn't have cvbs, so disable related section in device tree.
> >
> > Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
> > ---
> > arch/arm64/boot/dts/amlogic/Makefile | 1 +
> > .../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 26 ++++++++++++++++++++++
> > 2 files changed, 27 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> > index c31f29d66..49f3ac5d8 100644
> > --- a/arch/arm64/boot/dts/amlogic/Makefile
> > +++ b/arch/arm64/boot/dts/amlogic/Makefile
> > @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
> > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> > new file mode 100644
> > index 000000000..1096509b2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> > @@ -0,0 +1,26 @@
>
> [...]
>
> > +&external_phy {
> > + /* Realtek RTL8211F (0x001cc916) */
> > + eee-broken-1000t;
> > +};
> >
>
> I was thinking about this, and the `eee-broken-1000t;` should go into meson-gxl-s905d-p230.dts
> instead since the P230 should also have a broken EEE on the Realtek RTL8211F PHY.
>
> Thanks,
> Neil
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Neil, thanks for review. If add `eee-broken-1000t;` into meson-gxl-s905d-p230.dts, then this device
tree only include disable cvbs section, should I submit a separate patch for meson-gxl-s905d-p230.dts?
Yangxuan
next prev parent reply other threads:[~2018-11-09 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 17:29 [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1 He Yangxuan
2018-11-09 9:47 ` Neil Armstrong
2018-11-09 10:07 ` He Yangxuan [this message]
2018-11-09 10:08 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109100701.62vxl4wdgm5lwn36@raspberrypi \
--to=yangxuan8282@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).