From: Andrew Lunn <andrew@lunn.ch>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-amlogic@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 2/3] net: phy: add amlogic g12a mdio mux support
Date: Sat, 16 Mar 2019 03:54:48 +0100 [thread overview]
Message-ID: <20190316025448.GD29548@lunn.ch> (raw)
In-Reply-To: <20190314140135.19184-3-jbrunet@baylibre.com>
On Thu, Mar 14, 2019 at 03:01:34PM +0100, Jerome Brunet wrote:
>> +static int _g12a_enable_internal_mdio(struct g12a_mdio_mux *priv)
>
You would generally use the _ prefix when you have a locked and an
unlocked version. I don't see anything like this here. So please drop
the _ .
Nice to see the generic clock framework being used. I just wonder if
this is the correct place to have this clock code. Can it be made part
of the SoC clock code?
Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-16 2:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 14:01 [PATCH net-next 0/3] net: phy: add Amlogic g12a support Jerome Brunet
2019-03-14 14:01 ` [PATCH net-next 1/3] dt-bindings: net: phy: add g12a mdio mux documentation Jerome Brunet
2019-03-28 15:57 ` Rob Herring
2019-03-14 14:01 ` [PATCH net-next 2/3] net: phy: add amlogic g12a mdio mux support Jerome Brunet
2019-03-16 2:54 ` Andrew Lunn [this message]
2019-03-16 17:02 ` Jerome Brunet
2019-03-17 15:48 ` Andrew Lunn
2019-03-18 9:36 ` Jerome Brunet
2019-03-18 9:45 ` Neil Armstrong
2019-03-17 16:14 ` Andrew Lunn
2019-03-18 9:34 ` Jerome Brunet
2019-03-14 14:01 ` [PATCH net-next 3/3] net: phy: meson-gxl: add g12a support Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316025448.GD29548@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).