From: Greg KH <gregkh@linuxfoundation.org>
To: Matthias Maennich <maennich@google.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>,
lucas.de.marchi@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arch@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>,
Michal Simek <michal.simek@xilinx.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
mingo@redhat.com, geert@linux-m68k.org,
NXP Linux Team <linux-imx@nxp.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
tglx@linutronix.de, michal.lkml@markovi.net,
Scott Branden <sbranden@broadcom.com>,
Andrew Jeffery <andrew@aj.id.au>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-aspeed@lists.ozlabs.org, yamada.masahiro@socionext.com,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Kukjin Kim <kgene@kernel.org>,
kernel-team@android.com, sspatil@google.com,
linux-watchdog@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-arm-msm@vger.kernel.org, pombredanne@nexb.com,
linux-m68k@lists.linux-m68k.org,
linux-rpi-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, maco@android.com,
linux-arm-kernel@lists.infradead.org,
Barry Song <baohua@kernel.org>,
Johannes Thumshirn <morbidrsa@gmail.com>,
oneukum@suse.com, Patrice Chotard <patrice.chotard@st.com>,
Stefan Wahren <wahrenst@gmx.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
kstewart@linuxfoundation.org,
usb-storage@lists.one-eyed-alien.net,
linux-tegra@vger.kernel.org, patches@opensource.cirrus.com,
joel@joelfernandes.org, sam@ravnborg.org,
linux-rtc@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Benjamin Fair <benjaminfair@google.com>,
Eric Anholt <eric@anholt.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Nancy Yuen <yuenn@google.com>, Chen-Yu Tsai <wens@csie.org>,
bcm-kernel-feedback-list@broadcom.com,
Joel Stanley <joel@jms.id.au>,
stern@rowland.harvard.edu, arnd@arndb.de,
Ray Jui <rjui@broadcom.com>, Vladimir Zapolskiy <vz@mleia.com>,
Orson Zhai <orsonzhai@gmail.com>,
linux-hwmon@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Andreas Werner <andreas.werner@men.de>,
Avi Fishman <avifishman70@gmail.com>,
maco@google.com, jeyu@kernel.org, Shawn Guo <shawnguo@kernel.org>,
Baruch Siach <baruch@tkos.co.il>, Mans Rullgard <mans@mansr.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Tali Perry <tali.perry1@gmail.com>,
hpa@zytor.com, linux-scsi@vger.kernel.org,
openbmc@lists.ozlabs.org, x86@kernel.org,
Andy Gross <agross@kernel.org>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
linux-mediatek@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Baolin Wang <baolin.wang@linaro.org>,
Patrick Venture <venture@google.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace
Date: Wed, 21 Aug 2019 05:39:33 -0700 [thread overview]
Message-ID: <20190821123933.GC4059@kroah.com> (raw)
In-Reply-To: <20190821114955.12788-12-maennich@google.com>
On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote:
> Modules using these symbols are required to explicitly import the
> namespace. This patch was generated with the following steps and serves
> as a reference to use the symbol namespace feature:
>
> 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols
> in watchdog_core.c
> 2) make (see warnings during modpost about missing imports)
> 3) make nsdeps
>
> I used 'allmodconfig' for the above steps to ensure all occurrences are
> patched.
>
> Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this
> case as not only watchdog_core is defined in drivers/watchdog/Makefile.
> Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros
> to export into a different namespace.
>
> An alternative to this patch would be a single definition line before
> any use of EXPORT_SYMBOL*:
> #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE
>
> Signed-off-by: Matthias Maennich <maennich@google.com>
As we talked in chat, the cc: list for this patch was crazy :)
If you end up resending this (as odds are the mailing lists will trash
it for too many recipients), feel free to add:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Great work,
greg k-h
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-21 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190813121733.52480-1-maennich@google.com>
2019-08-21 11:49 ` [PATCH v3 00/11] Symbol Namespaces Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Matthias Maennich
2019-08-21 12:39 ` Greg KH [this message]
2019-08-21 14:59 ` Guenter Roeck
2019-08-21 16:28 ` Matthias Maennich
2019-08-21 12:46 ` [PATCH v3 00/11] Symbol Namespaces Nicolas Pitre
2019-08-21 13:37 ` Greg KH
2019-08-21 20:48 ` Nicolas Pitre
2019-08-21 13:11 ` Peter Zijlstra
2019-08-21 13:38 ` Greg KH
2019-08-21 14:03 ` Matthias Maennich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821123933.GC4059@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=andreas.werner@men.de \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=jerry.hoemann@hpe.com \
--cc=jeyu@kernel.org \
--cc=joel@jms.id.au \
--cc=joel@joelfernandes.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@android.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lucas.de.marchi@gmail.com \
--cc=ludovic.desroches@microchip.com \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=maennich@google.com \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=michal.simek@xilinx.com \
--cc=mingo@redhat.com \
--cc=morbidrsa@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=oneukum@suse.com \
--cc=openbmc@lists.ozlabs.org \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=patrice.chotard@st.com \
--cc=pombredanne@nexb.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sspatil@google.com \
--cc=stern@rowland.harvard.edu \
--cc=support.opensource@diasemi.com \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=venture@google.com \
--cc=vilhelm.gray@gmail.com \
--cc=vz@mleia.com \
--cc=wahrenst@gmx.net \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yuenn@google.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox