From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7242EC35671 for ; Mon, 24 Feb 2020 13:14:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4717220828 for ; Mon, 24 Feb 2020 13:14:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K26Q4XaS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4717220828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OCseB7+N1a5eP/kzDXv95yzp2I1yheL1SUnr2E2I0T8=; b=K26Q4XaSYxD7ES d/WU7LxV51+sRBVzei9XqgqqqeEvaGX2Gg/wYGxFUSEz8LMpXKNuIwUi/48//cgpCTLTYBwryHcq3 W4p4MA5WS7YPdta0WJguFntD0uxMAgakWImPowl0vShTDr+sR3HEacTDmluGs5vHZY/gOixXKj3ZT o1NHO1hRZp/G0f8ssdBlGL0UiL/CbtC2GU87lhawpqR/3HZ9njVHGHM0G0VSjmJ79btQk4+oW3qjx mr8ZeHgkuYrYO/fer0zEABWMwC1hnuj3N9Ty8s3FyJPh5oJJOQhuYJI4aWeH1JSygg/MehrJWztvn EJf9OCG651tNB8aaB/cA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6DZG-0006xE-BB; Mon, 24 Feb 2020 13:14:38 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6DZD-0006wh-Ey for linux-amlogic@lists.infradead.org; Mon, 24 Feb 2020 13:14:36 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 05:14:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,480,1574150400"; d="scan'208";a="255575855" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 24 Feb 2020 05:14:21 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 24 Feb 2020 15:14:20 +0200 Date: Mon, 24 Feb 2020 15:14:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sam Ravnborg Subject: Re: [PATCH 04/12] drm: Nuke mode->vrefresh Message-ID: <20200224131420.GW13686@intel.com> References: <20200219203544.31013-1-ville.syrjala@linux.intel.com> <20200219203544.31013-5-ville.syrjala@linux.intel.com> <20200222123240.GD28287@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200222123240.GD28287@ravnborg.org> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_051435_515273_44180739 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , nouveau@lists.freedesktop.org, Guido =?iso-8859-1?Q?G=FCnther?= , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Laurent Pinchart , Benjamin Gaignard , Thomas Hellstrom , Joonyoung Shim , Stefan Mavrodiev , Jerry Han , Ben Skeggs , VMware Graphics , Jagan Teki , Robert Chiras , Linus Walleij , Icenowy Zheng , Jonas Karlman , intel-gfx@lists.freedesktop.org, Inki Dae , CK Hu , linux-amlogic@lists.infradead.org, Vincent Abriou , Jernej Skrabec , Purism Kernel Team , Seung-Woo Kim , Kyungmin Park , Philipp Zabel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Feb 22, 2020 at 01:32:40PM +0100, Sam Ravnborg wrote: > Hi Ville. > = > Nice patch - and diffstat looks good: > > 63 files changed, 217 insertions(+), 392 deletions(-) > = > There is an item in the Documentation/gpu/todo.rst that > describes this. > Could you drop this from todo.rst in this patch too. Yeah, missed the TODO. Looks like there's one for hsync removal as well. > = > > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcd= e_dsi.c > > index bb6528b01cd0..6dca5344c0b3 100644 > > --- a/drivers/gpu/drm/mcde/mcde_dsi.c > > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > > @@ -538,7 +538,7 @@ static void mcde_dsi_setup_video_mode(struct mcde_d= si *d, > > */ > > /* (ps/s) / (pixels/s) =3D ps/pixels */ > > pclk =3D DIV_ROUND_UP_ULL(1000000000000, > > - (mode->vrefresh * mode->htotal * mode->vtotal)); > > + (drm_mode_vrefresh(mode) * mode->htotal * mode->vtotal)); > > dev_dbg(d->dev, "picoseconds between two pixels: %llu\n", > > pclk); > > = > = > This just caught my eye while browsing the patch. > It looks like a backward way to get the clock. Yep. I'll cook up a patch to switch this to ->clock. > = > But patch is fine, it was just a drive-by comment. > = > Whole patch is: > Reviewed-by: Sam Ravnborg > (with or without removal of todo item added) > = > Sam -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic