linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Juerg Haefliger <juerg.haefliger@canonical.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
	khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com,
	linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
Date: Thu, 18 Aug 2022 08:44:30 +0200	[thread overview]
Message-ID: <20220818084430.0ca10b30@smeagol> (raw)
In-Reply-To: <04115bee-5ddb-701f-ad18-d2c846155816@baylibre.com>


[-- Attachment #1.1: Type: text/plain, Size: 2172 bytes --]

On Wed, 17 Aug 2022 18:08:19 +0200
Neil Armstrong <narmstrong@baylibre.com> wrote:

> On 17/08/2022 16:05, Juerg Haefliger wrote:
> > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> > provide that information via modinfo.
> > 
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> >   .../staging/media/meson/vdec/vdec_platform.c  | 20 +++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> > index 88c9d72e1c83..c7750d4be848 100644
> > --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
> >   	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
> >   	.revision = VDEC_REVISION_SM1,
> >   };
> > +
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");  
> 
> Duplicate

Oh this is embarrassing :-(


> > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");  
> 
> DDDDDDDuplicate
> 
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");  
> 
> Duplicate
> 
> > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");  
> 
> With the duplicate entries removed, please add my:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Will do. Thanks for the review.

...Juerg


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2022-08-18  6:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 14:05 [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro Juerg Haefliger
2022-08-17 16:08 ` Neil Armstrong
2022-08-18  6:44   ` Juerg Haefliger [this message]
2022-08-18  6:48 ` [PATCH v2] " Juerg Haefliger
2023-01-26 15:32   ` [PATCH v2 resend] " Juerg Haefliger
2023-06-13  9:50     ` Juerg Haefliger
2023-06-13  9:59       ` Dan Carpenter
2023-06-13 15:39     ` [PATCH v2 resend 2] " Juerg Haefliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818084430.0ca10b30@smeagol \
    --to=juerg.haefliger@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mchehab@kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).