From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 260C5ECAAD2 for ; Fri, 26 Aug 2022 06:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MGEwyjURg21O2tyNNEDKlfJOrloUHj13IqueX5XSW+o=; b=z9r6tnsCRU+PRDJ1fp7idrONEk owVV+X10uF4+7Gp1G5GiIFdK5Yf78aXfAUSkBR9t37DiB02cbefgEfG9w20wpDOkg1hwc77d3hNQe nh2xqF8qNZuczVhWW8Y8SDqjPvQdpzYEjj6tNUel40XInosVUoTEp0MA3MdgxsOHJv51EPlnClIpe VbHMDZbKF8YPi4w+27/i5TL7wU4zXxhL/2LkK50o8+9av1GJsl/maIRF4l4pdoEP3BBFuxTc+Lpq+ 351MTvTw4bQ4QgJZnJFtCLPihg++RRFidByfrdkBn2+EOKC1kVo3TMYLvQelqN7B6rQSReti4fZ2K 3xdszSag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRT7J-00EsOL-Cd; Fri, 26 Aug 2022 06:46:57 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRT7F-00EsKQ-UO; Fri, 26 Aug 2022 06:46:55 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id AE6495801D4; Fri, 26 Aug 2022 02:46:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 26 Aug 2022 02:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1661496410; x=1661503610; bh=GDI1p03KIm VlfJybKQmUVUO7IOmo/SYqjAdeD+YEJlU=; b=kCGkvMU71YpuR26/BKv0WV1a8b HFbSpBa/AZvbeZIWSFNRmNXoz2q2vhGz0rySdhoz44mNNocXjRG1c14i1Y+F7n5h khGLctRYXvDyDUaCX3/TmOKGntJ3dN6hfgChVT5gyPCE86HKR7hr9xgOAv8j6lBT +LbtcVKIN8zD/4fhLAOM5Rvh4KkKHvwUKeff4bYQD8U2+oszeErGrhpQIaQf1WLE k0nC9C8EfvsvsWjz32WHx3SEEKR6Tp/89mJ92XfpIGVEHTapg1T46i87PI+LpJrE RMX4qLx5RWeXXU5yWBHcFxsL/OkjrdmyXnUY2+Kc7eN6XM3EPkBeNv2rhcjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661496410; x=1661503610; bh=GDI1p03KImVlfJybKQmUVUO7IOmo /SYqjAdeD+YEJlU=; b=v5dH7JbPy1IjrkFwNE91odQ9Pi2I1YbQg3CGPgZH5DNO PgS+UZwQI/9OIN3Mw+BswZMVY2PPrtphpUQ6SBehjCfhh+2siZ3Iflf53yf2gevY NRl0YUaJGBhFbnLLx3bIQn7923tn9oZuGG1lX38tW7IghHSLhccydpTz0QyPgfle w+BDa+BXIGvR6rp1T0xTjVg4qIbmditFP7NSonQ2ZoRoOZxAirvao0PF18843l6H QkCKw5hV4HXdoivMKM1u38gkuHb60F5gyv+vLagdPu1UlMBwltx3/qhJSSBZX4Sr DPzLhMHIJouKzESjiHxDBss0Prtt9IWN0WyxfkUmBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejgedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepjeevfeehfeekieffgeevleevtefgffefkedtfeeuhfettdegjeehgfeg udffffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Aug 2022 02:46:48 -0400 (EDT) Date: Fri, 26 Aug 2022 08:46:46 +0200 From: Maxime Ripard To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Kevin Hilman , Neil Armstrong , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option Message-ID: <20220826064646.ug2djacis7whybpd@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-34-3d53ae722097@cerno.tech> <20220824154543.bdtpz2evwzsjrdrz@houat> <3cc08f9d-9f01-b771-c16f-ea95acd7e7cd@tronnes.org> MIME-Version: 1.0 In-Reply-To: <3cc08f9d-9f01-b771-c16f-ea95acd7e7cd@tronnes.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_234654_468607_53120422 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1530574543878368416==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============1530574543878368416== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dmczm7av6szyde4h" Content-Disposition: inline --dmczm7av6szyde4h Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 25, 2022 at 02:41:27PM +0200, Noralf Tr=F8nnes wrote: > Den 24.08.2022 17.45, skrev Maxime Ripard: > > Hi Noralf, > >=20 > > On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Tr=F8nnes wrote: > >> Den 29.07.2022 18.35, skrev Maxime Ripard: > >>> Our new tv mode option allows to specify the TV mode from a property. > >>> However, it can still be useful, for example to avoid any boot time > >>> artifact, to set that property directly from the kernel command line. > >>> > >>> Let's add some code to allow it, and some unit tests to exercise that= code. > >>> > >>> Signed-off-by: Maxime Ripard > >>> > >> > >> In the subject it says "tv_mode property", but the property is called > >> "tv norm", so the option should be tv_norm? > >=20 > > Yeah... I don't know. mode is taken but it's obviously the best name. So > > I went with norm to avoid the (internal) conflict but I left mode for > > the user facing property. > >=20 > > I'm not sure what's best here, or maybe we can pick another name entire= ly? > >=20 >=20 > Why not just call it "tv mode" or even better "TV Mode". The state > member can be called tv_mode, but the mode_config member will need a > temporary name until the "mode" property is removed. tv_tv_mode or maybe > connector_tv_mode? Yeah, that seems like a good idea. Would legacy_tv_mode work for you? > But IMO, if there are no users of this property, adding it should have a > drm maintainers ack. Yep, of course :) Maxime --dmczm7av6szyde4h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYwhsVgAKCRDj7w1vZxhR xagcAQCspBwGYBSb/ilXsoY7WZaVorZ+0k/rDn3zQOob2qwY7wD+IadLV+q7Qw9q D1RIs0Z4w2lGo0vSFi33xoW6p6/S6wk= =qZ8U -----END PGP SIGNATURE----- --dmczm7av6szyde4h-- --===============1530574543878368416== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============1530574543878368416==--