From: Guenter Roeck <linux@roeck-us.net>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jean Delvare <jdelvare@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 4/4] hwmon: adm1177: simplify using devm_regulator_get_enable()
Date: Fri, 21 Oct 2022 10:22:51 -0700 [thread overview]
Message-ID: <20221021172251.GA1891003@roeck-us.net> (raw)
In-Reply-To: <7773541795f280db31dd981ffc21df8a630b794a.1666357434.git.mazziesaccount@gmail.com>
On Fri, Oct 21, 2022 at 04:19:04PM +0300, Matti Vaittinen wrote:
> Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> add_action_or_reset(regulator_disable)' and use the
> devm_regulator_get_enable() and drop the pointer to the regulator.
> This simplifies code and makes it less tempting to add manual control
> for the regulator which is also controlled by devm.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
Applied to hwmon-next.
Thanks,
Guenter
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-10-21 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:17 [PATCH v4 0/4] Use devm helpers for regulator get and enable Matti Vaittinen
2022-10-21 13:18 ` [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*() Matti Vaittinen
2022-10-21 13:24 ` Neil Armstrong
2022-10-21 15:02 ` Laurent Pinchart
2022-10-21 15:29 ` Neil Armstrong
2022-10-24 4:40 ` Vaittinen, Matti
2022-11-16 12:02 ` Vaittinen, Matti
2022-11-16 12:23 ` neil.armstrong
2022-10-21 13:18 ` [PATCH v4 2/4] gpu: drm: sii902x: Use devm_regulator_bulk_get_enable() Matti Vaittinen
2022-10-21 13:24 ` Matti Vaittinen
2022-10-24 15:47 ` Robert Foss
2022-10-21 13:18 ` [PATCH v4 3/4] hwmon: lm90: simplify using devm_regulator_get_enable() Matti Vaittinen
2022-10-21 17:21 ` Guenter Roeck
2022-10-21 13:19 ` [PATCH v4 4/4] hwmon: adm1177: " Matti Vaittinen
2022-10-21 17:22 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021172251.GA1891003@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Michael.Hennerich@analog.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox