RE: [PATCH 09/22] drm/kmb: Use GEM DMA fbdev emulation

Chrisanthus, Anitha
2023-03-06T17:19:48Z

Acked-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

> -----Original Message-----
> From: Thomas Zimmermann <tzimmermann@suse.de>
> Sent: Wednesday, March 1, 2023 7:31 AM
> To: javierm@redhat.com; maarten.lankhorst@linux.intel.com;
> mripard@kernel.org; airlied@gmail.com; daniel@ffwll.ch; andrew@aj.id.au;
> laurentiu.palcu@oss.nxp.com; l.stach@pengutronix.de;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; linux-imx@nxp.com; p.zabel@pengutronix.de;
> Chrisanthus, Anitha <anitha.chrisanthus@intel.com>;
> edmund.j.dea@intel.com; khilman@baylibre.com; jbrunet@baylibre.com;
> martin.blumenstingl@googlemail.com; alain.volmat@foss.st.com;
> yannick.fertre@foss.st.com; raphael.gallais-pou@foss.st.com;
> philippe.cornu@foss.st.com; mcoquelin.stm32@gmail.com;
> alexandre.torgue@foss.st.com; jernej.skrabec@gmail.com;
> samuel@sholland.org; jyri.sarha@iki.fi; tomba@kernel.org;
> linus.walleij@linaro.org; hyun.kwon@xilinx.com;
> laurent.pinchart@ideasonboard.com
> Cc: dri-devel@lists.freedesktop.org; linux-aspeed@lists.ozlabs.org; linux-arm-
> kernel@lists.infradead.org; linux-amlogic@lists.infradead.org; linux-
> stm32@st-md-mailman.stormreply.com; linux-sunxi@lists.linux.dev; Thomas
> Zimmermann <tzimmermann@suse.de>
> Subject: [PATCH 09/22] drm/kmb: Use GEM DMA fbdev emulation
>
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/kmb/kmb_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index d29c678f6c91..24035b53441c 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -15,7 +15,7 @@
>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_module.h>
> @@ -562,7 +562,7 @@ static int kmb_probe(struct platform_device *pdev)
> if (ret)
> goto err_register;
>
> - drm_fbdev_generic_setup(&kmb->drm, 0);
> + drm_fbdev_dma_setup(&kmb->drm, 0);
>
> return 0;
>
> --
> 2.39.2