Re: [PATCH V4] nvmem: add explicit config option to read old syntax fixed OF cells

Jernej Škrabec
2023-04-04T16:57:33Z

Dne torek, 04. april 2023 ob 00:55:40 CEST je Rafał Miłecki napisal(a):
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Binding for fixed NVMEM cells defined directly as NVMEM device subnodes
> has been deprecated. It has been replaced by the "fixed-layout" NVMEM
> layout binding.
>
> New syntax is meant to be clearer and should help avoiding imprecise
> bindings.
>
> NVMEM subsystem already supports the new binding. It should be a good
> idea to limit support for old syntax to existing drivers that actually
> support & use it (we can't break backward compatibility!). That way we
> additionally encourage new bindings & drivers to ignore deprecated
> binding.
>
> It wasn't clear (to me) if rtc and w1 code actually uses old syntax
> fixed cells. I enabled them to don't risk any breakage.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> [for meson-{efuse,mx-efuse}.c]
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> [for mtk-efuse.c, nvmem/core.c, nvmem-provider.h]
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> [MT8192, MT8195 Chromebooks]
> Tested-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> [for microchip-otpc.c]
> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> [SAMA7G5-EK]
> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> This is based on top of them
> [PATCH V6 3/3] nvmem: core: add support for fixed cells *layout*
>
> V2: Fix stm32-romem.c typo breaking its compilation
> Pick Martin's Acked-by
> Add paragraph about layouts deprecating add_legacy_fixed_of_cells
> V3: Update commit description:
> 1. Make it clear we're NOT dropping fixed cells support
> 2. Use nicer words (s/made sense/was totally safe/)
> 3. Explain fixed cells layout thing
> 4. Add paragraph with purpose of this commit
> V4: Completely rewrite commit message.
> Rename config option to "add_legacy_fixed_of_cells".
> ---
> drivers/mtd/mtdcore.c | 2 ++
> drivers/nvmem/apple-efuses.c | 1 +
> drivers/nvmem/core.c | 8 +++++---
> drivers/nvmem/imx-ocotp-scu.c | 1 +
> drivers/nvmem/imx-ocotp.c | 1 +
> drivers/nvmem/meson-efuse.c | 1 +
> drivers/nvmem/meson-mx-efuse.c | 1 +
> drivers/nvmem/microchip-otpc.c | 1 +
> drivers/nvmem/mtk-efuse.c | 1 +
> drivers/nvmem/qcom-spmi-sdam.c | 1 +
> drivers/nvmem/qfprom.c | 1 +
> drivers/nvmem/rave-sp-eeprom.c | 1 +
> drivers/nvmem/rockchip-efuse.c | 1 +
> drivers/nvmem/sc27xx-efuse.c | 1 +
> drivers/nvmem/sprd-efuse.c | 1 +
> drivers/nvmem/stm32-romem.c | 1 +
> drivers/nvmem/sunplus-ocotp.c | 1 +
> drivers/nvmem/sunxi_sid.c | 1 +

For sunxi_sid:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> drivers/nvmem/uniphier-efuse.c | 1 +
> drivers/nvmem/zynqmp_nvmem.c | 1 +
> drivers/rtc/nvmem.c | 1 +
> drivers/w1/slaves/w1_ds250x.c | 1 +
> include/linux/nvmem-provider.h | 2 ++
> 23 files changed, 29 insertions(+), 3 deletions(-)