Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string

Dmitry Rokosov
2023-07-04T17:09:24Z

On Tue, Jul 04, 2023 at 06:02:58PM +0100, Conor Dooley wrote:
> On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> > In the current implementation, the meson-a1 configuration incorporates a
> > unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> > driver due to its usage of the new console device name "ttyS".
> > Consequently, the previous compatibility tag designated for the
> > 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> > longer relevant to the current setup.
>
> I don't really see why you would remove the gx-uart to be honest, and
> not use it as a fallback. Neil's platform though, so his call :)
>

Because of amlogic,meson-gx-uart has legacy devname, we do not want to
use it in the A1.

> >
> > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > index c5567031ba12..6273b9c862b3 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > @@ -344,7 +344,7 @@ mux {
> > };
> >
> > uart_AO: serial@1c00 {
> > - compatible = "amlogic,meson-gx-uart",
> > + compatible = "amlogic,meson-a1-uart",
> > "amlogic,meson-ao-uart";
> > reg = <0x0 0x1c00 0x0 0x18>;
> > interrupts = <GIC_SPI 25 IRQ_TYPE_EDGE_RISING>;
> > @@ -354,7 +354,7 @@ uart_AO: serial@1c00 {
> > };
> >
> > uart_AO_B: serial@2000 {
> > - compatible = "amlogic,meson-gx-uart",
> > + compatible = "amlogic,meson-a1-uart",
> > "amlogic,meson-ao-uart";
> > reg = <0x0 0x2000 0x0 0x18>;
> > interrupts = <GIC_SPI 26 IRQ_TYPE_EDGE_RISING>;
> > --
> > 2.36.0
> >

--
Thank you,
Dmitry