From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7558BEB64DD for ; Sun, 16 Jul 2023 15:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M7fdrhRhOM+8iJqVr/AZguhumkVWFJkW5SPN+rD7ZTI=; b=vYoQ3cO7mUpZM7 nO36WyoxoWvjq3iT0V+dzyBXXmL8QgQb5CK0XgtPgekw1dmMkFDF04sRyU3JIleDr6w1E2CwWDuDa D8UzjjaZ7fMThMtIE+WOKMaSRN6aTZYtfkNOgVE+L9sPGkGdtLRLfZD1q/ZyTvqld9YFqBRKaXfPg f0WYObk2sdk0vO1NX9mD+8fPz67VlAbtPU3DgrWXR3vuM/yq/TEU1d8YiXStk3Co5gIdTkwEJ1kv2 DSGTf9iDn0vX2zW63lyYg75b64OtLFtS9dDZKwNjS8CchcQkCXzGW5C+F96Daf7A/4QEXm0JufWTh M7Z4nYsOSh0Ss60fvd3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qL3Ry-00CE5N-0R; Sun, 16 Jul 2023 15:14:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qL3Ru-00CE2Z-0T; Sun, 16 Jul 2023 15:14:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02D3260D2D; Sun, 16 Jul 2023 15:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE5EC433C8; Sun, 16 Jul 2023 15:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689520452; bh=1wl0Jpwzikj4jNSOLAVUejXKVhQnCaeA3Bu0jXd2X5U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oj17vjEU9LlvZQhHYVzP3Q2JhQdwCx2YaQ9mH86CS6f7RHiLS/jhsoLltG/uM6gkD BrsXX9sKuQ2tCdfFA2BallA7vl7+76XmD6Cfg5CyQOuDGhlwlnnBT96uLCXhOW6dMk Gse+M+/ORlCfdV3eLjutpzMuaCVIxoW3U8GRdn2JUfsNbAbRRaKiNe9rtVv3IW6bVc TrxMRPgjzRzTF12qKP5fszcsfuO4IrYagB8W0RRvJ0pn8ZZ9zzIiI/n37eiWXtBI+w Dwe4SJ3audVOn5fvcldahh3F62oHprTDftTcmEAjX9dnSitzAIye5QNSK0iAivkrLw AYbgaGGrnhjug== Date: Sun, 16 Jul 2023 16:14:02 +0100 From: Jonathan Cameron To: George Stark Cc: , , , , , , , , , , , Subject: Re: [PATCH v7 0/6] meson saradc: add iio channels to read channel 7 mux inputs Message-ID: <20230716161402.6bed56ef@jic23-huawei> In-Reply-To: <20230714114010.293440-1-gnstark@sberdevices.ru> References: <20230714114010.293440-1-gnstark@sberdevices.ru> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230716_081414_306192_DC69D818 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, 14 Jul 2023 14:37:47 +0300 George Stark wrote: Hi George, I think everything has been addressed from earlier reviews - hence... Applied to the togreg branch of iio.git. That is initially pushed out as testing for 0-day to see if it can find anything we missed. Thanks, Jonathan > Changelog: > > v1->v2: > split refactoring patch [1] into 4 smaller patches, fix comment style > > [1] https://lore.kernel.org/lkml/20230621062715.455652-2-gnstark@sberdevices.ru/ > > v2->v3: > remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion > > patch 'meson saradc: add enum for iio channel array indexes' > - change enum items prefix from INDEX_ to NUM_ since name 'channel index' is > more relevant to channel array index in iio world and with 2 tables our array index is > not always equal to channel number > - resolve conflicts after deleting [1] > - update commit message, previous patch [2] > - return channel number for temp channel. It wasn't used and isn't used currently > but may need later > > patch meson saradc: support reading from channel 7 mux inputs > - resolve conflicts after deleting [1] > - update commit message, previous patch [3] > - add routine find_channel_by_num to get channel by channel number > > [1] https://lore.kernel.org/lkml/20230623022334.791026-4-gnstark@sberdevices.ru/ > [2] https://lore.kernel.org/lkml/20230623022334.791026-5-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230623022334.791026-7-gnstark@sberdevices.ru/ > > v3->v4: > add new patch 'iio: adc: meson: remove unused timestamp channel' [1] > > patch 'iio: adc: meson: move enums declaration before' > update commit message, previous patch [2] > patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux' > update commit message, previous patch [3] > patch 'iio: adc: meson: add enum for iio channel numbers' > update commit message, previous patch [4] > patch 'iio: adc: meson: add channel labels' > update commit message, previous patch [5] > change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n") > patch 'iio: adc: meson: support reading from channel 7 mux' > rewrite enum meson_sar_adc_chan7_mux_sel definition and > read_label routine proposed by Andy [7], previous patch [6] > > [1] https://lore.kernel.org/lkml/20230705160413.000062e7@Huawei.com/ > [2] https://lore.kernel.org/lkml/20230627224017.1724097-2-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230627224017.1724097-3-gnstark@sberdevices.ru/ > [4] https://lore.kernel.org/lkml/20230627224017.1724097-4-gnstark@sberdevices.ru/ > [5] https://lore.kernel.org/lkml/20230627224017.1724097-5-gnstark@sberdevices.ru/ > [6] https://lore.kernel.org/lkml/20230627224017.1724097-6-gnstark@sberdevices.ru/ > [7] https://lore.kernel.org/lkml/ZJwGCNA+ZURri24i@smile.fi.intel.com/ > > v4->v5: > patch 'iio: adc: meson: move enums declaration before variables declaration' > update commit message, previous patch [1] > patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper' > update commit message, previous patch [2] > patch 'iio: adc: meson: add channel labels' > update commit message, previous patch [3] > patch 'iio: adc: meson: support reading from channel 7 mux inputs' > update commit message, previous patch [4] > > [1] https://lore.kernel.org/lkml/20230707153322.114302-3-gnstark@sberdevices.ru/ > [2] https://www.spinics.net/lists/linux-iio/msg80226.html > [3] https://www.spinics.net/lists/linux-iio/msg80227.html > [4] https://www.spinics.net/lists/linux-iio/msg80230.html > > v5->v6: > patch 'iio: adc: meson: move enums declaration before variables declaration' > update commit message, previous patch [1] > patch 'iio: adc: meson: support reading from channel 7 mux inputs' > update commit message, previous patch [2] > [1] https://www.spinics.net/lists/linux-iio/msg80315.html > [2] https://www.spinics.net/lists/linux-iio/msg80314.html > > v6->v7: > all patches: > add tag Reviewed-by: Andy Shevchenko > > George Stark (6): > iio: adc: meson: remove unused timestamp channel > iio: adc: meson: move enums declaration before variables declaration > iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper > iio: adc: meson: add enum for iio channel numbers > iio: adc: meson: add channel labels > iio: adc: meson: support reading from channel 7 mux inputs > > drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++-------- > 1 file changed, 134 insertions(+), 39 deletions(-) > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic