From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F117C83F01 for ; Sat, 26 Aug 2023 20:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tGCuBPgdatxi2r3EWrtwRX2fbiwfIA/IooU98o01W2o=; b=wjjAFSSPJCx6An r4cJtyVfq4a/9ZQmnyQgycHsonGg35sYruE8fKdyV8A00tTNM24Lsm1EHw0c6bCJMs9MzC+RtBl3Z ec9Yu3TQ8YGOXjQmDxwSkbJsc/urQyNwKaWIz7oxS3jJiTLLo9TBD6meo/HO7w67tZUkj3EiCWdZq UkCA59358aCjrckTKprCi9C30hZIyoKiI7mXXVDZanKf+hYfppw7RNZtW+jVKS6XrdD++Dg393uRL tZZrxnFbPQSR5BFC0Y92QQ1bT++1Q5fhnTgbFnF9Ycl5UbClSgOfKPYY1H9XwSoG2DhoJ9ojo/HUy KqxMGCmRpCpA4h0o1GZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZzRo-007BeS-2G; Sat, 26 Aug 2023 19:59:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZzRl-007Bdu-2A; Sat, 26 Aug 2023 19:59:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B130860CF7; Sat, 26 Aug 2023 19:59:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84168C433C8; Sat, 26 Aug 2023 19:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693079988; bh=wk7TTw46I9VQ1vaqjL5oYSR1MWRvL3QqszPe1Ac3vEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jUceMAv4p78ZNILkEQmopDvcIZ44XkSx8YyqCQzeVhrnFNDWN3wcMc8ZoERhQFETn c8e7ID/zkoi0nwVWXynboBvJsIvtCSXs4S3OcfJ2lr5Ac4GDBo5U/Nx3T1SLQfKXvo VPZa3kfJE565DVd7Jkrtr2glSNkantuwuRdZjw1A= Date: Sat, 26 Aug 2023 21:59:45 +0200 From: Greg Kroah-Hartman To: Lucas Tanure Cc: Dmitry Rokosov , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Xianwei Zhao , Nick , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC Message-ID: <2023082636-embolism-submitter-5e8c@gregkh> References: <20230814080128.143613-1-tanure@linux.com> <20230814080128.143613-2-tanure@linux.com> <20230823082940.t4xjgfzwpt2hsfst@CAB-WSD-L081021> <29cfd5ef-16ae-4960-a95e-13b58c090604@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <29cfd5ef-16ae-4960-a95e-13b58c090604@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230826_125949_783035_B6E69A70 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Aug 26, 2023 at 07:07:18PM +0100, Lucas Tanure wrote: > On 23-08-2023 09:29, Dmitry Rokosov wrote: > > Hello Lucas, > > > > Thank you for the patch! Please find my small comment below. > > > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > > > The new Amlogic T7 SoC does not have a always-on uart, > > > so add OF_EARLYCON_DECLARE for it. > > > > > > Signed-off-by: Lucas Tanure > > > Acked-by: Neil Armstrong > > > --- > > > Since v8: > > > - Fix issues with git send-mail command line > > > Since v7: > > > - Send to the correct maintainers > > > > > > drivers/tty/serial/meson_uart.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > > > index 790d910dafa5..c4f61d82fb72 100644 > > > --- a/drivers/tty/serial/meson_uart.c > > > +++ b/drivers/tty/serial/meson_uart.c > > > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > > meson_serial_early_console_setup); > > > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > > > + meson_serial_early_console_setup); > > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > > > #else > > > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > > applied patch series at [1] and the IRC discussion at [2]. > > > > Links: > > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > > > I asked Greg to drop this patch as is not need anymore. > T7 will use S4 TTY/UART code. I can't drop it, I need a revert :( _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic